From 50012b6f06848fea79f79a24d6cb4d1b4404b83a Mon Sep 17 00:00:00 2001 From: Zehua Zou <41586196+HuaHuaY@users.noreply.github.com> Date: Fri, 28 Nov 2025 21:10:26 +0800 Subject: [PATCH] add -std=c++23 in cpp-linter.yml --- .github/workflows/cpp-linter.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cpp-linter.yml b/.github/workflows/cpp-linter.yml index 5b511f2e0..4cc4e025d 100644 --- a/.github/workflows/cpp-linter.yml +++ b/.github/workflows/cpp-linter.yml @@ -29,6 +29,9 @@ on: jobs: cpp-linter: runs-on: ubuntu-24.04 + permissions: + contents: read + pull-requests: write steps: - name: Checkout iceberg-cpp uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0 @@ -57,8 +60,9 @@ jobs: thread-comments: true ignore: 'build|cmake_modules|ci' database: build + verbosity: 'debug' # need '-fno-builtin-std-forward_like', see https://github.com/llvm/llvm-project/issues/101614 - extra-args: '-I$PWD/src -I$PWD/build/src -fno-builtin-std-forward_like' + extra-args: '-std=c++23 -I$PWD/src -I$PWD/build/src -fno-builtin-std-forward_like' - name: Fail fast?! if: steps.linter.outputs.checks-failed != 0 run: |