From 7f6ce34ffc6ab8182dcc9840faf60c9943110d54 Mon Sep 17 00:00:00 2001 From: "xiao.dong" Date: Fri, 28 Nov 2025 17:03:52 +0800 Subject: [PATCH 1/3] test: test cpplint build --- .github/workflows/cpp-linter.yml | 2 +- src/iceberg/result.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cpp-linter.yml b/.github/workflows/cpp-linter.yml index 5b511f2e0..098888654 100644 --- a/.github/workflows/cpp-linter.yml +++ b/.github/workflows/cpp-linter.yml @@ -58,7 +58,7 @@ jobs: ignore: 'build|cmake_modules|ci' database: build # need '-fno-builtin-std-forward_like', see https://github.com/llvm/llvm-project/issues/101614 - extra-args: '-I$PWD/src -I$PWD/build/src -fno-builtin-std-forward_like' + extra-args: '-I$PWD/src -I$PWD/build/src -fno-builtin-std-forward_like -D__cpp_concepts=202002L' - name: Fail fast?! if: steps.linter.outputs.checks-failed != 0 run: | diff --git a/src/iceberg/result.h b/src/iceberg/result.h index ddc428a23..0d95de670 100644 --- a/src/iceberg/result.h +++ b/src/iceberg/result.h @@ -43,6 +43,7 @@ enum class ErrorKind { kInvalidManifest, kInvalidManifestList, kInvalidSchema, + kInvalidStatistics, kIOError, kJsonParseError, kNamespaceNotEmpty, @@ -104,6 +105,7 @@ DEFINE_ERROR_FUNCTION(InvalidExpression) DEFINE_ERROR_FUNCTION(InvalidManifest) DEFINE_ERROR_FUNCTION(InvalidManifestList) DEFINE_ERROR_FUNCTION(InvalidSchema) +DEFINE_ERROR_FUNCTION(InvalidStatistics) DEFINE_ERROR_FUNCTION(IOError) DEFINE_ERROR_FUNCTION(JsonParseError) DEFINE_ERROR_FUNCTION(NamespaceNotEmpty) From fa2b4ddcf0edd51653a65d67341e58db5baf254c Mon Sep 17 00:00:00 2001 From: "xiao.dong" Date: Fri, 28 Nov 2025 17:15:55 +0800 Subject: [PATCH 2/3] test --- .github/workflows/cpp-linter.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-linter.yml b/.github/workflows/cpp-linter.yml index 098888654..5b511f2e0 100644 --- a/.github/workflows/cpp-linter.yml +++ b/.github/workflows/cpp-linter.yml @@ -58,7 +58,7 @@ jobs: ignore: 'build|cmake_modules|ci' database: build # need '-fno-builtin-std-forward_like', see https://github.com/llvm/llvm-project/issues/101614 - extra-args: '-I$PWD/src -I$PWD/build/src -fno-builtin-std-forward_like -D__cpp_concepts=202002L' + extra-args: '-I$PWD/src -I$PWD/build/src -fno-builtin-std-forward_like' - name: Fail fast?! if: steps.linter.outputs.checks-failed != 0 run: | From 4c552aadaf966a8f9fcdb751523f7c9e9ed0330c Mon Sep 17 00:00:00 2001 From: "xiao.dong" Date: Fri, 28 Nov 2025 18:01:00 +0800 Subject: [PATCH 3/3] update --- .github/workflows/cpp-linter.yml | 2 +- src/iceberg/result.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/cpp-linter.yml b/.github/workflows/cpp-linter.yml index 5b511f2e0..098888654 100644 --- a/.github/workflows/cpp-linter.yml +++ b/.github/workflows/cpp-linter.yml @@ -58,7 +58,7 @@ jobs: ignore: 'build|cmake_modules|ci' database: build # need '-fno-builtin-std-forward_like', see https://github.com/llvm/llvm-project/issues/101614 - extra-args: '-I$PWD/src -I$PWD/build/src -fno-builtin-std-forward_like' + extra-args: '-I$PWD/src -I$PWD/build/src -fno-builtin-std-forward_like -D__cpp_concepts=202002L' - name: Fail fast?! if: steps.linter.outputs.checks-failed != 0 run: | diff --git a/src/iceberg/result.h b/src/iceberg/result.h index 0d95de670..ddc428a23 100644 --- a/src/iceberg/result.h +++ b/src/iceberg/result.h @@ -43,7 +43,6 @@ enum class ErrorKind { kInvalidManifest, kInvalidManifestList, kInvalidSchema, - kInvalidStatistics, kIOError, kJsonParseError, kNamespaceNotEmpty, @@ -105,7 +104,6 @@ DEFINE_ERROR_FUNCTION(InvalidExpression) DEFINE_ERROR_FUNCTION(InvalidManifest) DEFINE_ERROR_FUNCTION(InvalidManifestList) DEFINE_ERROR_FUNCTION(InvalidSchema) -DEFINE_ERROR_FUNCTION(InvalidStatistics) DEFINE_ERROR_FUNCTION(IOError) DEFINE_ERROR_FUNCTION(JsonParseError) DEFINE_ERROR_FUNCTION(NamespaceNotEmpty)