Skip to content

Commit d6dceae

Browse files
committed
insert a build step
1 parent e171cab commit d6dceae

File tree

2 files changed

+12
-17
lines changed

2 files changed

+12
-17
lines changed

.github/workflows/cpp-linter.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,11 @@ jobs:
3131
runs-on: ubuntu-24.04
3232
steps:
3333
- uses: actions/checkout@v4
34+
- name: Run build
35+
run: |
36+
mkdir build && cd build
37+
cmake .. -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
38+
cmake --build .
3439
- uses: cpp-linter/cpp-linter-action@v2.13.3
3540
id: linter
3641
continue-on-error: true
@@ -43,8 +48,7 @@ jobs:
4348
lines-changed-only: true
4449
thread-comments: true
4550
ignore: 'build|cmake_modules|ci'
46-
database: build/compile_commands.json
47-
extra-args: '-std=c++20 -Wall'
51+
database: build
4852
- name: Fail fast?!
4953
if: steps.linter.outputs.checks-failed != 0
5054
run: |

api/iceberg/table.h

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,24 +20,15 @@
2020
#pragma once
2121

2222
#include <memory>
23-
24-
25-
26-
#include <string_view>
23+
#include <string_view>
2724

2825
namespace iceberg {
2926

30-
class Table {
31-
public:
32-
virtual ~Table( ) = default;
33-
34-
virtual std::string_view print() const = 0;
35-
36-
37-
static std::unique_ptr<Table> create();
38-
39-
private:
40-
int SOME_ID = 1;
27+
class Table {
28+
public:
29+
virtual ~Table() = default;
30+
virtual std::string_view print() const = 0;
31+
static std::unique_ptr<Table> create();
4132
};
4233

4334
} // namespace iceberg

0 commit comments

Comments
 (0)