Skip to content

Commit 3c74603

Browse files
committed
refactor: remove duplicate Commit() declaration from PendingUpdate template
Remove Commit() from PendingUpdate<T> since it's already declared in PendingUpdateBase with full documentation. The template class inherits it automatically. This follows DRY principle and avoids maintaining duplicate documentation.
1 parent aa0c756 commit 3c74603

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

src/iceberg/pending_update.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -87,14 +87,6 @@ class ICEBERG_EXPORT PendingUpdate : public PendingUpdateBase {
8787
/// - InvalidArgument: if pending changes are conflicting
8888
virtual Result<T> Apply() = 0;
8989

90-
/// \brief Apply and commit the pending changes to the table
91-
///
92-
/// \return Status::OK if the commit was successful, or an error:
93-
/// - ValidationFailed: if update cannot be applied to current metadata
94-
/// - CommitFailed: if update cannot be committed due to conflicts
95-
/// - CommitStateUnknown: if commit success state is unknown
96-
Status Commit() override = 0;
97-
9890
protected:
9991
PendingUpdate() = default;
10092
};

0 commit comments

Comments
 (0)