add TODO

wgtmac · wgtmac · commit 1d94ccef9899 · 2025-08-19T01:58:11.000+08:00
diff --git a/src/iceberg/avro/avro_data_util.cc b/src/iceberg/avro/avro_data_util.cc
@@ -515,13 +515,15 @@ Status ExtractDatumFromArray(const ::arrow::Array& array, int64_t index,
       return {};
     }
 
+    // TODO(gangwu): support LARGE_STRING.
     case ::arrow::Type::STRING: {
       const auto& string_array =
           internal::checked_cast<const ::arrow::StringArray&>(array);
       datum->value<std::string>() = string_array.GetString(index);
       return {};
     }
 
+    // TODO(gangwu): support LARGE_BINARY.
     case ::arrow::Type::BINARY: {
       const auto& binary_array =
           internal::checked_cast<const ::arrow::BinaryArray&>(array);

Original file line number	Diff line number	Diff line change
`@@ -515,13 +515,15 @@ Status ExtractDatumFromArray(const ::arrow::Array& array, int64_t index,`
`515`	`515`	`return {};`
`516`	`516`	`}`
`517`	`517`
	`518`	`+ // TODO(gangwu): support LARGE_STRING.`
`518`	`519`	`case ::arrow::Type::STRING: {`
`519`	`520`	`const auto& string_array =`
`520`	`521`	`internal::checked_cast<const ::arrow::StringArray&>(array);`
`521`	`522`	`datum->value<std::string>() = string_array.GetString(index);`
`522`	`523`	`return {};`
`523`	`524`	`}`
`524`	`525`
	`526`	`+ // TODO(gangwu): support LARGE_BINARY.`
`525`	`527`	`case ::arrow::Type::BINARY: {`
`526`	`528`	`const auto& binary_array =`
`527`	`529`	`internal::checked_cast<const ::arrow::BinaryArray&>(array);`