Remove test and example. Leave it for the client.

Author: arturobernalg

httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2MultiplexingRequester.java

@@ -89,10 +89,10 @@ public class H2MultiplexingRequester extends AsyncRequester {
     private final H2ConnPool connPool;
 
     /**
-     * Hard cap on per-connection queued / in-flight requests.
+     * Hard cap on per-connection queued / in-flight commands.
      * {@code <= 0} disables the cap.
      */
-    private final int maxRequestsPerConnection;
+    private final int maxCommandsPerConnection;
 
     /**
      * Use {@link H2MultiplexingRequesterBootstrap} to create instances of this class.
@@ -108,12 +108,12 @@ public H2MultiplexingRequester(
             final TlsStrategy tlsStrategy,
             final IOReactorMetricsListener threadPoolListener,
             final IOWorkerSelector workerSelector,
-            final int maxRequestsPerConnection) {
+            final int maxCommandsPerConnection) {
         super(eventHandlerFactory, ioReactorConfig, ioSessionDecorator, exceptionCallback, sessionListener,
                 ShutdownCommand.GRACEFUL_IMMEDIATE_CALLBACK, DefaultAddressResolver.INSTANCE,
                 threadPoolListener, workerSelector);
         this.connPool = new H2ConnPool(this, addressResolver, tlsStrategy);
-        this.maxRequestsPerConnection = maxRequestsPerConnection;
+        this.maxCommandsPerConnection = maxCommandsPerConnection;
     }
 
     public void closeIdle(final TimeValue idleTime) {
@@ -254,12 +254,12 @@ public void failed(final Exception cause) {
                             }
 
                         };
-                        final int max = maxRequestsPerConnection;
+                        final int max = maxCommandsPerConnection;
                         if (max > 0) {
                             final int current = ioSession.getPendingCommandCount();
                             if (current >= 0 && current >= max) {
                                 exchangeHandler.failed(new RejectedExecutionException(
-                                        "Maximum number of pending requests per connection reached (max=" + max + ")"));
+                                        "Maximum number of pending commands per connection reached (max=" + max + ")"));
                                 exchangeHandler.releaseResources();
                                 return;
                             }

httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2MultiplexingRequesterBootstrap.java

@@ -77,7 +77,7 @@ public class H2MultiplexingRequesterBootstrap {
 
     private IOReactorMetricsListener threadPoolListener;
 
-    private int maxRequestsPerConnection;
+    private int maxCommandsPerConnection;
 
     private H2MultiplexingRequesterBootstrap() {
         this.routeEntries = new ArrayList<>();
@@ -184,19 +184,19 @@ public final H2MultiplexingRequesterBootstrap setIOReactorMetricsListener(final
     }
 
     /**
-     * Sets a hard limit on the number of pending request execution commands that can be queued per connection.
+     * Sets a hard limit on the number of pending commands execution commands that can be queued per connection.
      * When the limit is reached, new submissions fail fast with {@link java.util.concurrent.RejectedExecutionException}.
      * A value {@code <= 0} disables the limit (default).
      * Note: this limit applies to commands waiting in the connection's internal queue (backlog). HTTP/2 in-flight
      * concurrency is governed separately by protocol settings (e.g. MAX_CONCURRENT_STREAMS).
      *
-     * @param max maximum number of pending requests per connection; {@code <= 0} to disable the limit.
+     * @param max maximum number of pending commands per connection; {@code <= 0} to disable the limit.
      * @return this instance.
      * @since 5.5
      */
     @Experimental
-    public final H2MultiplexingRequesterBootstrap setMaxRequestsPerConnection(final int max) {
-        this.maxRequestsPerConnection = max;
+    public final H2MultiplexingRequesterBootstrap setMaxCommandsPerConnection(final int max) {
+        this.maxCommandsPerConnection = max;
         return this;
     }
 
@@ -295,7 +295,7 @@ public H2MultiplexingRequester create() {
                 tlsStrategy != null ? tlsStrategy : new H2ClientTlsStrategy(),
                 threadPoolListener,
                 null,
-                maxRequestsPerConnection);
+                maxCommandsPerConnection);
     }
 
 }

httpcore5-h2/src/test/java/org/apache/hc/core5/http2/examples/H2MaxRequestsPerConnectionLocalExample.java

@@ -138,7 +138,7 @@ public void handle(
         final H2MultiplexingRequester requester = H2MultiplexingRequesterBootstrap.bootstrap()
                 .setIOReactorConfig(ioReactorConfig)
                 .setH2Config(H2Config.custom().setPushEnabled(false).build())
-                .setMaxRequestsPerConnection(maxPerConn)
+                .setMaxCommandsPerConnection(maxPerConn)
                 .create();