Skip to content

Commit 89620e5

Browse files
committed
Upgrade Apache RAT
During local development, I'm regularly annoyed by spurious RAT failures. While RAT does have some limitations -- for example, because it never shells out to `git`, it can't ignore untracked files -- newer versions do have improved support for `.gitignore` files, including the global gitignore file when present at `~/.config/git/ignore` (the default location). Additionally, the default exclusions have been improved, so we no longer need quite as much manual configuration. Specific changes: 1. Bumped `apache-rat-plugin` directly to 0.17. (In the version of the Apache parent POM we are using, there is no property we can override to do this.) 2. Removed exclusions that are obsolete or covered by our defaults. 3. Changed `apache-rat:check` to only run in `:httpclient5-parent`, instead of separately validating each subproject. 4. Changed `<exclude>` to `<inputExclude>` as the former is now deprecated.
1 parent 1c96bde commit 89620e5

1 file changed

Lines changed: 10 additions & 12 deletions

File tree

pom.xml

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -384,25 +384,23 @@
384384
<plugin>
385385
<groupId>org.apache.rat</groupId>
386386
<artifactId>apache-rat-plugin</artifactId>
387+
<version>0.17</version>
387388
<executions>
388389
<execution>
389390
<phase>verify</phase>
391+
<inherited>false</inherited>
390392
<goals>
391393
<goal>check</goal>
392394
</goals>
393395
</execution>
394396
</executions>
395-
<configuration>
396-
<excludes>
397-
<exclude>src/docbkx/resources/**</exclude>
398-
<exclude>src/test/resources/*.truststore</exclude>
399-
<exclude>src/test/resources/*.serialized</exclude>
400-
<exclude>.checkstyle</exclude>
401-
<exclude>.externalToolBuilders/**</exclude>
402-
<exclude>maven-eclipse.xml</exclude>
403-
<exclude>**/serial</exclude>
404-
<exclude>**/index.txt</exclude>
405-
</excludes>
397+
<configuration combine.self="override">
398+
<inputExcludes>
399+
<inputExclude>**/maven-eclipse.xml</inputExclude>
400+
<inputExclude>**/*.pem</inputExclude>
401+
<inputExclude>**/index.txt</inputExclude>
402+
<inputExclude>**/serial</inputExclude>
403+
</inputExcludes>
406404
</configuration>
407405
</plugin>
408406
<plugin>
@@ -538,4 +536,4 @@
538536
</plugins>
539537
</reporting>
540538

541-
</project>
539+
</project>

0 commit comments

Comments
 (0)