From f3b6fdd794171fe8992b4024f881dec1c974f97a Mon Sep 17 00:00:00 2001 From: Jochen Theodorou Date: Wed, 10 Dec 2025 18:07:15 +0100 Subject: [PATCH] GROOVY-8373: Fix resource leak in filterLine Writable.writeTo method The filterLine method returns a Writable whose writeTo method reads from a BufferedReader but never closes it, causing the underlying file handle to remain open and cause resource leaks. This fix wraps the filtering logic in writeTo within a try-finally block to ensure the BufferedReader is closed after use. --- .../groovy/runtime/IOGroovyMethods.java | 22 +++++++++++-------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/src/main/java/org/codehaus/groovy/runtime/IOGroovyMethods.java b/src/main/java/org/codehaus/groovy/runtime/IOGroovyMethods.java index e104966b6d7..671cc329425 100644 --- a/src/main/java/org/codehaus/groovy/runtime/IOGroovyMethods.java +++ b/src/main/java/org/codehaus/groovy/runtime/IOGroovyMethods.java @@ -1500,17 +1500,21 @@ public static Writable filterLine(Reader reader, @ClosureParams(value=SimpleType return new Writable() { @Override public Writer writeTo(Writer out) throws IOException { - BufferedWriter bw = new BufferedWriter(out); - String line; - BooleanClosureWrapper bcw = new BooleanClosureWrapper(closure); - while ((line = br.readLine()) != null) { - if (bcw.call(line)) { - bw.write(line); - bw.newLine(); + try { + BufferedWriter bw = new BufferedWriter(out); + String line; + BooleanClosureWrapper bcw = new BooleanClosureWrapper(closure); + while ((line = br.readLine()) != null) { + if (bcw.call(line)) { + bw.write(line); + bw.newLine(); + } } + bw.flush(); + return out; + } finally { + closeWithWarning(br); } - bw.flush(); - return out; } @Override