From 97deb69ad4933c0329f3530652d7707056035303 Mon Sep 17 00:00:00 2001 From: Jeremiah Bowen Date: Wed, 25 Feb 2026 09:39:01 -0600 Subject: [PATCH] chore: remove unused pgsql configuration from Helm chart values ### Summary This PR removes the commented `pgsql` configuration block from the Helm chart `values.yaml`. ### Motivation The chart currently exposes commented PostgreSQL configuration that appears to suggest PostgreSQL is supported, but: - The chart only implements MySQL configuration paths. - The `pgsql` values are not wired into templates. - Setting `option.database=pgsql` does not produce a working deployment. This creates confusion for users and leads to time spent attempting to configure an unsupported path. ### Change - Removes the commented `pgsql` configuration block from values.yaml. - Leaves MySQL as the clearly supported database option. ### Benefit - Reduces ambiguity around supported database backends. - Prevents users from attempting a non-functional configuration. - Improves chart clarity and maintainability. If/when PostgreSQL support becomes fully implemented, the configuration can be reintroduced with complete wiring and documentation. Happy to help reintroduce when full support exists. --- charts/devlake/templates/secrets.yaml | 2 -- charts/devlake/values.yaml | 51 --------------------------- 2 files changed, 53 deletions(-) diff --git a/charts/devlake/templates/secrets.yaml b/charts/devlake/templates/secrets.yaml index 47d2298..bc4db55 100644 --- a/charts/devlake/templates/secrets.yaml +++ b/charts/devlake/templates/secrets.yaml @@ -24,8 +24,6 @@ stringData: {{- if (eq .Values.option.database "mysql") }} MYSQL_PASSWORD: "{{ .Values.mysql.password }}" MYSQL_ROOT_PASSWORD: "{{ .Values.mysql.rootPassword }}" -#{{- else if (eq .Values.option.database "pgsql")}} -# POSTGRES_PASSWORD: "{{ .Values.pgsql.password }}" {{- end }} {{- end }} diff --git a/charts/devlake/values.yaml b/charts/devlake/values.yaml index fdc5067..78c165a 100644 --- a/charts/devlake/values.yaml +++ b/charts/devlake/values.yaml @@ -127,57 +127,6 @@ mysql: loadBalancerIP: "" extraLabels: {} -# pgsql: -# # if use external pgsql server, please set true -# # by default using false, chart will create a single pgsql instance -# useExternal: false - -# # the external pgsql server address -# externalServer: 127.0.0.1 - -# # external pgsql port -# externalPort: 5432 -# # the username for devlake database -# username: merico - -# # the password for devlake database -# password: merico - -# # the database for devlake -# database: lake - -# # storage for pgsql -# storage: -# # the storage class for pv, leave empty will using default -# class: "" -# size: 5Gi - -# # image for pgsql -# image: -# repository: postgres -# tag: 14.5 -# pullPolicy: IfNotPresent - -# # resources config for pgsql if have -# resources: {} - -# # nodeSelector config for pgsql if have -# nodeSelector: {} - -# # tolerations config for pgsql if have -# tolerations: [] - -# # affinity config for pgsql if have -# affinity: {} - -# extraLabels: {} - -# securityContext: {} - -# containerSecurityContext: {} - -# annotations: {} - # dependency chart values grafana: enabled: true