From f955cde75293db729aa4e605d15e8129e846bbf2 Mon Sep 17 00:00:00 2001 From: lani_karrot Date: Mon, 19 Jan 2026 14:22:26 +0900 Subject: [PATCH 1/4] test: add reservoir cross language test cases --- .../sampling/ReservoirCrossLanguageTest.java | 209 +++++++++++++++++- 1 file changed, 205 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java b/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java index 717874a93..96ef22d8c 100644 --- a/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java +++ b/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java @@ -22,6 +22,7 @@ import org.apache.datasketches.common.ArrayOfDoublesSerDe; import org.apache.datasketches.common.ArrayOfLongsSerDe; import org.apache.datasketches.common.ArrayOfStringsSerDe; +import org.apache.datasketches.common.ResizeFactor; import org.testng.annotations.Test; import java.io.IOException; @@ -74,7 +75,7 @@ public void generateReservoirLongsSketchSampling() throws IOException { final ReservoirLongsSketch sk = ReservoirLongsSketch.getInstance( predeterminedSamples, n, - org.apache.datasketches.common.ResizeFactor.X8, + ResizeFactor.X8, k ); @@ -83,6 +84,56 @@ public void generateReservoirLongsSketchSampling() throws IOException { } } + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateReservoirLongsUnionEmpty() throws IOException { + final int maxK = 128; + final ReservoirLongsUnion union = ReservoirLongsUnion.newInstance(maxK); + + Files.newOutputStream(javaPath.resolve("reservoir_longs_union_empty_maxk" + maxK + "_java.sk")) + .write(union.toByteArray()); + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateReservoirLongsUnionExact() throws IOException { + final int maxK = 128; + final int[] nArr = {1, 10, 32, 100, 128}; + + for (final int n : nArr) { + final ReservoirLongsUnion union = ReservoirLongsUnion.newInstance(maxK); + for (int i = 0; i < n; i++) { + union.update(i); + } + Files.newOutputStream(javaPath.resolve("reservoir_longs_union_exact_n" + n + "_maxk" + maxK + "_java.sk")) + .write(union.toByteArray()); + } + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateReservoirLongsUnionSampling() throws IOException { + final int[] maxKArr = {32, 64, 128}; + final long n = 1000; + + for (final int maxK : maxKArr) { + final long[] predeterminedSamples = new long[maxK]; + for (int i = 0; i < maxK; i++) { + predeterminedSamples[i] = i * 2; + } + + final ReservoirLongsSketch sk = ReservoirLongsSketch.getInstance( + predeterminedSamples, + n, + ResizeFactor.X8, + maxK + ); + + final ReservoirLongsUnion union = ReservoirLongsUnion.newInstance(maxK); + union.update(sk); + + Files.newOutputStream(javaPath.resolve("reservoir_longs_union_sampling_n" + n + "_maxk" + maxK + "_java.sk")) + .write(union.toByteArray()); + } + } + @Test(groups = {GENERATE_JAVA_FILES}) public void generateReservoirItemsSketchLongEmpty() throws IOException { final int k = 128; @@ -121,7 +172,7 @@ public void generateReservoirItemsSketchLongSampling() throws IOException { final ReservoirItemsSketch sk = ReservoirItemsSketch.newInstance( predeterminedSamples, n, - org.apache.datasketches.common.ResizeFactor.X8, + ResizeFactor.X8, k ); @@ -168,7 +219,7 @@ public void generateReservoirItemsSketchDoubleSampling() throws IOException { final ReservoirItemsSketch sk = ReservoirItemsSketch.newInstance( predeterminedSamples, n, - org.apache.datasketches.common.ResizeFactor.X8, + ResizeFactor.X8, k ); @@ -215,7 +266,7 @@ public void generateReservoirItemsSketchStringSampling() throws IOException { final ReservoirItemsSketch sk = ReservoirItemsSketch.newInstance( predeterminedSamples, n, - org.apache.datasketches.common.ResizeFactor.X8, + ResizeFactor.X8, k ); @@ -223,4 +274,154 @@ public void generateReservoirItemsSketchStringSampling() throws IOException { .write(sk.toByteArray(new ArrayOfStringsSerDe())); } } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateReservoirItemsUnionLongEmpty() throws IOException { + final int maxK = 128; + final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + + Files.newOutputStream(javaPath.resolve("reservoir_items_union_long_empty_maxk" + maxK + "_java.sk")) + .write(union.toByteArray(new ArrayOfLongsSerDe())); + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateReservoirItemsUnionLongExact() throws IOException { + final int maxK = 128; + final int[] nArr = {1, 10, 32, 100, 128}; + + for (final int n : nArr) { + final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + for (int i = 0; i < n; i++) { + union.update((long) i); + } + Files.newOutputStream(javaPath.resolve("reservoir_items_union_long_exact_n" + n + "_maxk" + maxK + "_java.sk")) + .write(union.toByteArray(new ArrayOfLongsSerDe())); + } + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateReservoirItemsUnionLongSampling() throws IOException { + final int[] maxKArr = {32, 64, 128}; + final long n = 1000; + + for (final int maxK : maxKArr) { + final java.util.ArrayList predeterminedSamples = new java.util.ArrayList<>(); + for (int i = 0; i < maxK; i++) { + predeterminedSamples.add((long) (i * 2)); + } + + final ReservoirItemsSketch sk = ReservoirItemsSketch.newInstance( + predeterminedSamples, + n, + ResizeFactor.X8, + maxK + ); + + final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + union.update(sk); + + Files.newOutputStream(javaPath.resolve("reservoir_items_union_long_sampling_n" + n + "_maxk" + maxK + "_java.sk")) + .write(union.toByteArray(new ArrayOfLongsSerDe())); + } + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateReservoirItemsUnionDoubleEmpty() throws IOException { + final int maxK = 128; + final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + + Files.newOutputStream(javaPath.resolve("reservoir_items_union_double_empty_maxk" + maxK + "_java.sk")) + .write(union.toByteArray(new ArrayOfDoublesSerDe())); + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateReservoirItemsUnionDoubleExact() throws IOException { + final int maxK = 128; + final int[] nArr = {1, 10, 32, 100, 128}; + + for (final int n : nArr) { + final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + for (int i = 0; i < n; i++) { + union.update((double) i); + } + Files.newOutputStream(javaPath.resolve("reservoir_items_union_double_exact_n" + n + "_maxk" + maxK + "_java.sk")) + .write(union.toByteArray(new ArrayOfDoublesSerDe())); + } + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateReservoirItemsUnionDoubleSampling() throws IOException { + final int[] maxKArr = {32, 64, 128}; + final long n = 1000; + + for (final int maxK : maxKArr) { + final java.util.ArrayList predeterminedSamples = new java.util.ArrayList<>(); + for (int i = 0; i < maxK; i++) { + predeterminedSamples.add((double) (i * 2)); + } + + final ReservoirItemsSketch sk = ReservoirItemsSketch.newInstance( + predeterminedSamples, + n, + ResizeFactor.X8, + maxK + ); + + final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + union.update(sk); + + Files.newOutputStream(javaPath.resolve("reservoir_items_union_double_sampling_n" + n + "_maxk" + maxK + "_java.sk")) + .write(union.toByteArray(new ArrayOfDoublesSerDe())); + } + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateReservoirItemsUnionStringEmpty() throws IOException { + final int maxK = 128; + final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + + Files.newOutputStream(javaPath.resolve("reservoir_items_union_string_empty_maxk" + maxK + "_java.sk")) + .write(union.toByteArray(new ArrayOfStringsSerDe())); + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateReservoirItemsUnionStringExact() throws IOException { + final int maxK = 128; + final int[] nArr = {1, 10, 32, 100, 128}; + + for (final int n : nArr) { + final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + for (int i = 0; i < n; i++) { + union.update("item" + i); + } + Files.newOutputStream(javaPath.resolve("reservoir_items_union_string_exact_n" + n + "_maxk" + maxK + "_java.sk")) + .write(union.toByteArray(new ArrayOfStringsSerDe())); + } + } + + @Test(groups = {GENERATE_JAVA_FILES}) + public void generateReservoirItemsUnionStringSampling() throws IOException { + final int[] maxKArr = {32, 64, 128}; + final long n = 1000; + + for (final int maxK : maxKArr) { + final java.util.ArrayList predeterminedSamples = new java.util.ArrayList<>(); + for (int i = 0; i < maxK; i++) { + predeterminedSamples.add("item" + (i * 2)); + } + + final ReservoirItemsSketch sk = ReservoirItemsSketch.newInstance( + predeterminedSamples, + n, + ResizeFactor.X8, + maxK + ); + + final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + union.update(sk); + + Files.newOutputStream(javaPath.resolve("reservoir_items_union_string_sampling_n" + n + "_maxk" + maxK + "_java.sk")) + .write(union.toByteArray(new ArrayOfStringsSerDe())); + } + } } From 1b8eaa5b02ec40ac79e5195b4b9dd4e212e643d4 Mon Sep 17 00:00:00 2001 From: lani_karrot Date: Mon, 19 Jan 2026 14:28:59 +0900 Subject: [PATCH 2/4] style: remove final --- .../sampling/ReservoirCrossLanguageTest.java | 81 ++++++++++--------- 1 file changed, 41 insertions(+), 40 deletions(-) diff --git a/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java b/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java index 96ef22d8c..f045b7e28 100644 --- a/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java +++ b/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java @@ -27,6 +27,7 @@ import java.io.IOException; import java.nio.file.Files; +import java.util.ArrayList; import static org.apache.datasketches.common.TestUtil.GENERATE_JAVA_FILES; import static org.apache.datasketches.common.TestUtil.javaPath; @@ -86,8 +87,8 @@ public void generateReservoirLongsSketchSampling() throws IOException { @Test(groups = {GENERATE_JAVA_FILES}) public void generateReservoirLongsUnionEmpty() throws IOException { - final int maxK = 128; - final ReservoirLongsUnion union = ReservoirLongsUnion.newInstance(maxK); + int maxK = 128; + ReservoirLongsUnion union = ReservoirLongsUnion.newInstance(maxK); Files.newOutputStream(javaPath.resolve("reservoir_longs_union_empty_maxk" + maxK + "_java.sk")) .write(union.toByteArray()); @@ -95,11 +96,11 @@ public void generateReservoirLongsUnionEmpty() throws IOException { @Test(groups = {GENERATE_JAVA_FILES}) public void generateReservoirLongsUnionExact() throws IOException { - final int maxK = 128; - final int[] nArr = {1, 10, 32, 100, 128}; + int maxK = 128; + int[] nArr = {1, 10, 32, 100, 128}; for (final int n : nArr) { - final ReservoirLongsUnion union = ReservoirLongsUnion.newInstance(maxK); + ReservoirLongsUnion union = ReservoirLongsUnion.newInstance(maxK); for (int i = 0; i < n; i++) { union.update(i); } @@ -110,23 +111,23 @@ public void generateReservoirLongsUnionExact() throws IOException { @Test(groups = {GENERATE_JAVA_FILES}) public void generateReservoirLongsUnionSampling() throws IOException { - final int[] maxKArr = {32, 64, 128}; - final long n = 1000; + int[] maxKArr = {32, 64, 128}; + long n = 1000; for (final int maxK : maxKArr) { - final long[] predeterminedSamples = new long[maxK]; + long[] predeterminedSamples = new long[maxK]; for (int i = 0; i < maxK; i++) { predeterminedSamples[i] = i * 2; } - final ReservoirLongsSketch sk = ReservoirLongsSketch.getInstance( + ReservoirLongsSketch sk = ReservoirLongsSketch.getInstance( predeterminedSamples, n, ResizeFactor.X8, maxK ); - final ReservoirLongsUnion union = ReservoirLongsUnion.newInstance(maxK); + ReservoirLongsUnion union = ReservoirLongsUnion.newInstance(maxK); union.update(sk); Files.newOutputStream(javaPath.resolve("reservoir_longs_union_sampling_n" + n + "_maxk" + maxK + "_java.sk")) @@ -277,8 +278,8 @@ public void generateReservoirItemsSketchStringSampling() throws IOException { @Test(groups = {GENERATE_JAVA_FILES}) public void generateReservoirItemsUnionLongEmpty() throws IOException { - final int maxK = 128; - final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + int maxK = 128; + ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); Files.newOutputStream(javaPath.resolve("reservoir_items_union_long_empty_maxk" + maxK + "_java.sk")) .write(union.toByteArray(new ArrayOfLongsSerDe())); @@ -286,11 +287,11 @@ public void generateReservoirItemsUnionLongEmpty() throws IOException { @Test(groups = {GENERATE_JAVA_FILES}) public void generateReservoirItemsUnionLongExact() throws IOException { - final int maxK = 128; - final int[] nArr = {1, 10, 32, 100, 128}; + int maxK = 128; + int[] nArr = {1, 10, 32, 100, 128}; for (final int n : nArr) { - final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); for (int i = 0; i < n; i++) { union.update((long) i); } @@ -301,23 +302,23 @@ public void generateReservoirItemsUnionLongExact() throws IOException { @Test(groups = {GENERATE_JAVA_FILES}) public void generateReservoirItemsUnionLongSampling() throws IOException { - final int[] maxKArr = {32, 64, 128}; - final long n = 1000; + int[] maxKArr = {32, 64, 128}; + long n = 1000; for (final int maxK : maxKArr) { - final java.util.ArrayList predeterminedSamples = new java.util.ArrayList<>(); + java.util.ArrayList predeterminedSamples = new java.util.ArrayList<>(); for (int i = 0; i < maxK; i++) { predeterminedSamples.add((long) (i * 2)); } - final ReservoirItemsSketch sk = ReservoirItemsSketch.newInstance( + ReservoirItemsSketch sk = ReservoirItemsSketch.newInstance( predeterminedSamples, n, ResizeFactor.X8, maxK ); - final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); union.update(sk); Files.newOutputStream(javaPath.resolve("reservoir_items_union_long_sampling_n" + n + "_maxk" + maxK + "_java.sk")) @@ -327,8 +328,8 @@ public void generateReservoirItemsUnionLongSampling() throws IOException { @Test(groups = {GENERATE_JAVA_FILES}) public void generateReservoirItemsUnionDoubleEmpty() throws IOException { - final int maxK = 128; - final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + int maxK = 128; + ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); Files.newOutputStream(javaPath.resolve("reservoir_items_union_double_empty_maxk" + maxK + "_java.sk")) .write(union.toByteArray(new ArrayOfDoublesSerDe())); @@ -336,11 +337,11 @@ public void generateReservoirItemsUnionDoubleEmpty() throws IOException { @Test(groups = {GENERATE_JAVA_FILES}) public void generateReservoirItemsUnionDoubleExact() throws IOException { - final int maxK = 128; - final int[] nArr = {1, 10, 32, 100, 128}; + int maxK = 128; + int[] nArr = {1, 10, 32, 100, 128}; for (final int n : nArr) { - final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); for (int i = 0; i < n; i++) { union.update((double) i); } @@ -351,23 +352,23 @@ public void generateReservoirItemsUnionDoubleExact() throws IOException { @Test(groups = {GENERATE_JAVA_FILES}) public void generateReservoirItemsUnionDoubleSampling() throws IOException { - final int[] maxKArr = {32, 64, 128}; - final long n = 1000; + int[] maxKArr = {32, 64, 128}; + long n = 1000; for (final int maxK : maxKArr) { - final java.util.ArrayList predeterminedSamples = new java.util.ArrayList<>(); + ArrayList predeterminedSamples = new java.util.ArrayList<>(); for (int i = 0; i < maxK; i++) { predeterminedSamples.add((double) (i * 2)); } - final ReservoirItemsSketch sk = ReservoirItemsSketch.newInstance( + ReservoirItemsSketch sk = ReservoirItemsSketch.newInstance( predeterminedSamples, n, ResizeFactor.X8, maxK ); - final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); union.update(sk); Files.newOutputStream(javaPath.resolve("reservoir_items_union_double_sampling_n" + n + "_maxk" + maxK + "_java.sk")) @@ -377,8 +378,8 @@ public void generateReservoirItemsUnionDoubleSampling() throws IOException { @Test(groups = {GENERATE_JAVA_FILES}) public void generateReservoirItemsUnionStringEmpty() throws IOException { - final int maxK = 128; - final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + int maxK = 128; + ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); Files.newOutputStream(javaPath.resolve("reservoir_items_union_string_empty_maxk" + maxK + "_java.sk")) .write(union.toByteArray(new ArrayOfStringsSerDe())); @@ -386,11 +387,11 @@ public void generateReservoirItemsUnionStringEmpty() throws IOException { @Test(groups = {GENERATE_JAVA_FILES}) public void generateReservoirItemsUnionStringExact() throws IOException { - final int maxK = 128; - final int[] nArr = {1, 10, 32, 100, 128}; + int maxK = 128; + int[] nArr = {1, 10, 32, 100, 128}; for (final int n : nArr) { - final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); for (int i = 0; i < n; i++) { union.update("item" + i); } @@ -401,23 +402,23 @@ public void generateReservoirItemsUnionStringExact() throws IOException { @Test(groups = {GENERATE_JAVA_FILES}) public void generateReservoirItemsUnionStringSampling() throws IOException { - final int[] maxKArr = {32, 64, 128}; - final long n = 1000; + int[] maxKArr = {32, 64, 128}; + long n = 1000; for (final int maxK : maxKArr) { - final java.util.ArrayList predeterminedSamples = new java.util.ArrayList<>(); + ArrayList predeterminedSamples = new java.util.ArrayList<>(); for (int i = 0; i < maxK; i++) { predeterminedSamples.add("item" + (i * 2)); } - final ReservoirItemsSketch sk = ReservoirItemsSketch.newInstance( + ReservoirItemsSketch sk = ReservoirItemsSketch.newInstance( predeterminedSamples, n, ResizeFactor.X8, maxK ); - final ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); + ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); union.update(sk); Files.newOutputStream(javaPath.resolve("reservoir_items_union_string_sampling_n" + n + "_maxk" + maxK + "_java.sk")) From 4f4a67cbccca461660f56fc7b91b290d46f5d2df Mon Sep 17 00:00:00 2001 From: lani_karrot Date: Mon, 19 Jan 2026 14:30:56 +0900 Subject: [PATCH 3/4] style: short import path --- .../sampling/ReservoirCrossLanguageTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java b/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java index f045b7e28..df83b84ae 100644 --- a/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java +++ b/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java @@ -99,7 +99,7 @@ public void generateReservoirLongsUnionExact() throws IOException { int maxK = 128; int[] nArr = {1, 10, 32, 100, 128}; - for (final int n : nArr) { + for (int n : nArr) { ReservoirLongsUnion union = ReservoirLongsUnion.newInstance(maxK); for (int i = 0; i < n; i++) { union.update(i); @@ -290,7 +290,7 @@ public void generateReservoirItemsUnionLongExact() throws IOException { int maxK = 128; int[] nArr = {1, 10, 32, 100, 128}; - for (final int n : nArr) { + for (int n : nArr) { ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); for (int i = 0; i < n; i++) { union.update((long) i); @@ -306,7 +306,7 @@ public void generateReservoirItemsUnionLongSampling() throws IOException { long n = 1000; for (final int maxK : maxKArr) { - java.util.ArrayList predeterminedSamples = new java.util.ArrayList<>(); + ArrayList predeterminedSamples = new ArrayList<>(); for (int i = 0; i < maxK; i++) { predeterminedSamples.add((long) (i * 2)); } @@ -340,7 +340,7 @@ public void generateReservoirItemsUnionDoubleExact() throws IOException { int maxK = 128; int[] nArr = {1, 10, 32, 100, 128}; - for (final int n : nArr) { + for (int n : nArr) { ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); for (int i = 0; i < n; i++) { union.update((double) i); @@ -356,7 +356,7 @@ public void generateReservoirItemsUnionDoubleSampling() throws IOException { long n = 1000; for (final int maxK : maxKArr) { - ArrayList predeterminedSamples = new java.util.ArrayList<>(); + ArrayList predeterminedSamples = new ArrayList<>(); for (int i = 0; i < maxK; i++) { predeterminedSamples.add((double) (i * 2)); } @@ -390,7 +390,7 @@ public void generateReservoirItemsUnionStringExact() throws IOException { int maxK = 128; int[] nArr = {1, 10, 32, 100, 128}; - for (final int n : nArr) { + for (int n : nArr) { ReservoirItemsUnion union = ReservoirItemsUnion.newInstance(maxK); for (int i = 0; i < n; i++) { union.update("item" + i); @@ -406,7 +406,7 @@ public void generateReservoirItemsUnionStringSampling() throws IOException { long n = 1000; for (final int maxK : maxKArr) { - ArrayList predeterminedSamples = new java.util.ArrayList<>(); + ArrayList predeterminedSamples = new ArrayList<>(); for (int i = 0; i < maxK; i++) { predeterminedSamples.add("item" + (i * 2)); } From 309209856f937f7f3945b2bf1e71c5c25ee25894 Mon Sep 17 00:00:00 2001 From: lani_karrot Date: Mon, 19 Jan 2026 14:32:33 +0900 Subject: [PATCH 4/4] style: remove final --- .../datasketches/sampling/ReservoirCrossLanguageTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java b/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java index df83b84ae..781fbebca 100644 --- a/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java +++ b/src/test/java/org/apache/datasketches/sampling/ReservoirCrossLanguageTest.java @@ -114,7 +114,7 @@ public void generateReservoirLongsUnionSampling() throws IOException { int[] maxKArr = {32, 64, 128}; long n = 1000; - for (final int maxK : maxKArr) { + for (int maxK : maxKArr) { long[] predeterminedSamples = new long[maxK]; for (int i = 0; i < maxK; i++) { predeterminedSamples[i] = i * 2; @@ -305,7 +305,7 @@ public void generateReservoirItemsUnionLongSampling() throws IOException { int[] maxKArr = {32, 64, 128}; long n = 1000; - for (final int maxK : maxKArr) { + for (int maxK : maxKArr) { ArrayList predeterminedSamples = new ArrayList<>(); for (int i = 0; i < maxK; i++) { predeterminedSamples.add((long) (i * 2)); @@ -355,7 +355,7 @@ public void generateReservoirItemsUnionDoubleSampling() throws IOException { int[] maxKArr = {32, 64, 128}; long n = 1000; - for (final int maxK : maxKArr) { + for (int maxK : maxKArr) { ArrayList predeterminedSamples = new ArrayList<>(); for (int i = 0; i < maxK; i++) { predeterminedSamples.add((double) (i * 2)); @@ -405,7 +405,7 @@ public void generateReservoirItemsUnionStringSampling() throws IOException { int[] maxKArr = {32, 64, 128}; long n = 1000; - for (final int maxK : maxKArr) { + for (int maxK : maxKArr) { ArrayList predeterminedSamples = new ArrayList<>(); for (int i = 0; i < maxK; i++) { predeterminedSamples.add("item" + (i * 2));