Skip to content

Commit f6dccad

Browse files
committed
Minor change requested in code review
1 parent 27e15ba commit f6dccad

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/udf.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ use arrow::pyarrow::ToPyArrow;
2424
use datafusion::arrow::array::{make_array, ArrayData};
2525
use datafusion::arrow::datatypes::DataType;
2626
use datafusion::arrow::pyarrow::{FromPyArrow, PyArrowType};
27+
use datafusion::common::internal_err;
2728
use datafusion::error::DataFusionError;
2829
use datafusion::logical_expr::{
2930
ColumnarValue, ReturnFieldArgs, ScalarFunctionArgs, ScalarUDF, ScalarUDFImpl, Signature,
@@ -105,7 +106,9 @@ impl ScalarUDFImpl for PythonFunctionScalarUDF {
105106
}
106107

107108
fn return_type(&self, _arg_types: &[DataType]) -> datafusion::common::Result<DataType> {
108-
unimplemented!()
109+
internal_err!(
110+
"return_field should not be called when return_field_from_args is implemented."
111+
)
109112
}
110113

111114
fn return_field_from_args(

0 commit comments

Comments
 (0)