Add check for dead code

Author: timsaucer

examples/tpch/q07_volume_shipping.py

@@ -80,7 +80,7 @@
 # not match these will result in a null value and then get filtered out.
 #
 # To do the same using a simple filter would be:
-# df_nation = df_nation.filter((F.col("n_name") == nation_1) | (F.col("n_name") == nation_2))
+# df_nation = df_nation.filter((F.col("n_name") == nation_1) | (F.col("n_name") == nation_2)) # noqa: ERA001
 df_nation = df_nation.with_column(
     "n_name",
     F.case(col("n_name"))

examples/tpch/q12_ship_mode_order_priority.py

@@ -73,7 +73,7 @@
 # matches either of the two values, but we want to show doing some array operations in this
 # example. If you want to see this done with filters, comment out the above line and uncomment
 # this one.
-# df = df.filter((col("l_shipmode") == lit(SHIP_MODE_1)) | (col("l_shipmode") == lit(SHIP_MODE_2)))
+# df = df.filter((col("l_shipmode") == lit(SHIP_MODE_1)) | (col("l_shipmode") == lit(SHIP_MODE_2))) # noqa: ERA001
 
 
 # We need order priority, so join order df to line item

pyproject.toml

@@ -87,10 +87,8 @@ ignore = [
     "TD002",   # Do not require author names in TODO statements
     "TD003",   # Allow TODO lines
     "PLR0913", # Allow many arguments in function definition
+    "PD901",   # Allow variable name df
     # TODO: Enable all of the following, but this PR is getting too large already
-#    "TRY003",
-    "PD901",
-    "ERA001",
     "ANN001",
     "ANN202",
     "PTH",
@@ -130,9 +128,10 @@ extend-allowed-calls = ["lit", "datafusion.lit"]
     "PT004",
 ]
 "examples/*" = ["D", "W505", "E501", "T201", "S101", "PLR2004"]
-"dev/*" = ["D", "E", "T", "S", "PLR", "C", "SIM", "UP", "EXE", "N817"]
-"benchmarks/*" = ["D", "F", "T", "BLE", "FURB", "PLR", "E", "TD", "TRY", "S", "SIM", "EXE", "UP"]
+"dev/*" = ["D", "E", "T", "S", "PLR", "C", "SIM", "UP", "EXE", "N817", "ERA001"]
+"benchmarks/*" = ["D", "F", "T", "BLE", "FURB", "PLR", "E", "TD", "TRY", "S", "SIM", "EXE", "UP", "ERA001"]
 "docs/*" = ["D"]
+"docs/source/conf.py" = ["ERA001"]
 
 [tool.codespell]
 skip = [

python/datafusion/dataframe.py

@@ -78,7 +78,7 @@ class Compression(Enum):
     LZ4 = "lz4"
     # lzo is not implemented yet
     # https://github.com/apache/arrow-rs/issues/6970
-    # LZO = "lzo"
+    # LZO = "lzo"  # noqa: ERA001
     ZSTD = "zstd"
     LZ4_RAW = "lz4_raw"
 

python/tests/test_aggregation.py

@@ -88,7 +88,7 @@ def df_aggregate_100():
             f.covar_samp(column("b"), column("c")),
             lambda a, b, c, d: np.array(np.cov(b, c, ddof=1)[0][1]),
         ),
-        # f.grouping(col_a),  # No physical plan implemented yet
+        # f.grouping(col_a),  # noqa: ERA001 No physical plan implemented yet
         (f.max(column("a")), lambda a, b, c, d: np.array(np.max(a))),
         (f.mean(column("b")), lambda a, b, c, d: np.array(np.mean(b))),
         (f.median(column("b")), lambda a, b, c, d: np.array(np.median(b))),