get offer for vpc

DaanHoogland · Copilot · web-flow · commit e8cebc652d01 · 2026-01-13T14:21:35.000+01:00
Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java b/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
@@ -1032,8 +1032,11 @@ public PublicIp assignSourceNatIpAddressToGuestNetwork(Account owner, Network gu
     private boolean isRouted(Network guestNetwork) {
         VpcOffering vpcOffer = null;
         NetworkOffering netOffer = _networkOfferingDao.findById(guestNetwork.getNetworkOfferingId());
-        if (netOffer.isForVpc()) {
-            vpcOffer = vpcOfferingDao.findById(guestNetwork.getVpcId());
+        if (netOffer.isForVpc() && guestNetwork.getVpcId() != null) {
+            VpcVO vpc = _vpcDao.findById(guestNetwork.getVpcId());
+            if (vpc != null) {
+                vpcOffer = vpcOfferingDao.findById(vpc.getVpcOfferingId());
+            }
         }
         return netOffer.getRoutingMode() != null || (vpcOffer != null && vpcOffer.getRoutingMode() != null);
     }

Original file line number	Diff line number	Diff line change
`@@ -1032,8 +1032,11 @@ public PublicIp assignSourceNatIpAddressToGuestNetwork(Account owner, Network gu`
`1032`	`1032`	`private boolean isRouted(Network guestNetwork) {`
`1033`	`1033`	`VpcOffering vpcOffer = null;`
`1034`	`1034`	`NetworkOffering netOffer = _networkOfferingDao.findById(guestNetwork.getNetworkOfferingId());`
`1035`		`- if (netOffer.isForVpc()) {`
`1036`		`- vpcOffer = vpcOfferingDao.findById(guestNetwork.getVpcId());`
	`1035`	`+ if (netOffer.isForVpc() && guestNetwork.getVpcId() != null) {`
	`1036`	`+ VpcVO vpc = _vpcDao.findById(guestNetwork.getVpcId());`
	`1037`	`+ if (vpc != null) {`
	`1038`	`+ vpcOffer = vpcOfferingDao.findById(vpc.getVpcOfferingId());`
	`1039`	`+ }`
`1037`	`1040`	`}`
`1038`	`1041`	`return netOffer.getRoutingMode() != null \|\| (vpcOffer != null && vpcOffer.getRoutingMode() != null);`
`1039`	`1042`	`}`