Skip to content

Commit 89ba48b

Browse files
author
root
committed
docker: address review comments in s390x Dockerfile
Signed-off-by: Niyam Siwach <niyam@ibm.com> Signed-off-by: Viddya K <viddya.k@ibm.com>
1 parent 51d38cb commit 89ba48b

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

tools/docker/Dockerfile.s390x

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ RUN apt-get -y update && apt-get install -y \
4040
python3-setuptools \
4141
python3-pip \
4242
python3-mysql.connector \
43+
# Required on s390x as pre-built wheels for bcrypt, cryptography, and cffi are unavailable, necessitating source builds.
4344
python3-bcrypt \
4445
python3-cryptography \
4546
python3-cffi \
@@ -66,20 +67,20 @@ RUN find /var/lib/mysql -type f -exec touch {} \; && \
6667
mvn -Pdeveloper -pl developer -Ddeploydb-simulator; \
6768
MARVIN_FILE=`find /root/tools/marvin/dist/ -name "Marvin*.tar.gz"`; \
6869
rm -rf /usr/bin/s390x-linux-gnu-gcc && \
69-
ln -s /usr/bin/gcc-10 /usr/bin/s390x-linux-gnu-gcc; \
70+
ln -s /usr/bin/gcc-10 /usr/bin/s390x-linux-gnu-gcc && \
71+
pip3 install maturin && \
7072
pip3 install $MARVIN_FILE
7173

72-
RUN apt-get install -y nodejs npm build-essential python3 g++ make && \
73-
bash
74+
RUN apt-get install -y nodejs npm build-essential python3 g++ make
7475

7576
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.4/install.sh | bash && \
7677
. /root/.nvm/nvm.sh && \
77-
nvm install 10 && \
78-
nvm use 10 && \
78+
nvm install 16 && \
79+
nvm use 16 && \
7980
NVM_BIN="$(dirname "$(nvm which node)")" && \
8081
ln -sf "$NVM_BIN/node" /usr/local/bin/node && \
8182
ln -sf "$NVM_BIN/npm" /usr/local/bin/npm && \
82-
cd ui && npm install && npm rebuild node-sass
83+
cd ui && npm rebuild node-sass && npm install
8384

8485

8586
VOLUME /var/lib/mysql

0 commit comments

Comments
 (0)