Skip to content

Commit 6b071d6

Browse files
committed
use appropriate zoneId during clone bkp offering
1 parent 4a130ce commit 6b071d6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -354,12 +354,12 @@ public BackupOffering cloneBackupOffering(final CloneBackupOfferingCmd cmd) {
354354
final Long zoneId = cmd.getZoneId() != null ? cmd.getZoneId() : sourceOffering.getZoneId();
355355

356356
if (!Objects.equals(sourceOffering.getExternalId(), externalId)) {
357-
final BackupProvider provider = getBackupProvider(sourceOffering.getZoneId());
358-
if (!provider.isValidProviderOffering(sourceOffering.getZoneId(), externalId)) {
359-
throw new CloudRuntimeException("Backup offering '" + externalId + "' does not exist on provider " + provider.getName() + " on zone " + sourceOffering.getZoneId());
357+
final BackupProvider provider = getBackupProvider(zoneId);
358+
if (!provider.isValidProviderOffering(zoneId, externalId)) {
359+
throw new CloudRuntimeException("Backup offering '" + externalId + "' does not exist on provider " + provider.getName() + " on zone " + zoneId);
360360
}
361361

362-
final BackupOffering existingOffering = backupOfferingDao.findByExternalId(externalId, sourceOffering.getZoneId());
362+
final BackupOffering existingOffering = backupOfferingDao.findByExternalId(externalId, zoneId);
363363
if (existingOffering != null) {
364364
throw new CloudRuntimeException("A backup offering with external ID '" + externalId + "' already exists in this zone");
365365
}

0 commit comments

Comments
 (0)