Remove unused method + fix tests

Author: winterhazel

plugins/database/quota/src/main/java/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java

@@ -228,24 +228,6 @@ protected Pair<List<QuotaSummaryResponse>, Integer> getQuotaSummaryResponseWithL
         return getQuotaSummaryResponse(accountId, keyword, domainId, domainPath, cmd);
     }
 
-
-    protected Long getAccountIdByAccountName(String accountName, Long domainId, Account caller) {
-        if (ObjectUtils.anyNull(accountName, domainId)) {
-            return null;
-        }
-
-        Domain domain = domainDao.findByIdIncludingRemoved(domainId);
-        _accountMgr.checkAccess(caller, domain);
-
-        Account account = _accountDao.findAccountIncludingRemoved(accountName, domainId);
-
-        if (account == null) {
-            throw new InvalidParameterValueException(String.format("Account name [%s] or domain id [%s] is invalid.", accountName, domainId));
-        }
-
-        return account.getAccountId();
-    }
-
     /**
      * Retrieves the domain path of the caller's domain (if the caller is Domain Admin) for filtering in the quota summary query.
      * @return null if the caller is an Admin or the domain path of the caller's domain if the caller is a Domain Admin.

plugins/database/quota/src/test/java/org/apache/cloudstack/api/response/QuotaResponseBuilderImplTest.java

@@ -554,7 +554,6 @@ public void createQuotaSummaryResponseTestNotListAllAndAllAccountTypesReturnsSin
 
             for (Account.Type type : Account.Type.values()) {
                 Mockito.doReturn(type).when(accountMock).getType();
-                Mockito.doReturn("ROOT").when(quotaResponseBuilderSpy).getDomainPathByDomainIdForDomainAdmin(accountMock);
 
                 Pair<List<QuotaSummaryResponse>, Integer> result = quotaResponseBuilderSpy.createQuotaSummaryResponse(cmd);
                 Assert.assertEquals(quotaSummaryResponseMock1, result);
@@ -650,37 +649,6 @@ public void getQuotaEmailConfigurationVoTestExistingConfiguration() {
         assertFalse(result.isEnabled());
     }
 
-    @Test
-    public void getAccountIdByAccountNameTestAccountNameIsNullReturnsNull() {
-        Assert.assertNull(quotaResponseBuilderSpy.getAccountIdByAccountName(null, 1l, accountMock));
-    }
-
-    @Test
-    public void getAccountIdByAccountNameTestDomainIdIsNullReturnsNull() {
-        Assert.assertNull(quotaResponseBuilderSpy.getAccountIdByAccountName("test", null, accountMock));
-    }
-
-    @Test(expected = InvalidParameterValueException.class)
-    public void getAccountIdByAccountNameTestAccountIsNullThrowsInvalidParameterValueException() {
-        Mockito.lenient().doNothing().when(accountManagerMock).checkAccess(Mockito.any(Account.class), Mockito.any(Domain.class));
-        Mockito.doReturn(null).when(accountDaoMock).findAccountIncludingRemoved(Mockito.anyString(), Mockito.anyLong());
-
-        quotaResponseBuilderSpy.getAccountIdByAccountName("test", 1l, accountMock);
-    }
-
-    @Test
-    public void getAccountIdByAccountNameTestAccountIsNotNullReturnsAccountId() {
-        Long expected = 61l;
-
-        Mockito.lenient().doNothing().when(accountManagerMock).checkAccess(Mockito.any(Account.class), Mockito.any(Domain.class));
-        Mockito.doReturn(accountMock).when(accountDaoMock).findAccountIncludingRemoved(Mockito.anyString(), Mockito.anyLong());
-        Mockito.doReturn(expected).when(accountMock).getAccountId();
-
-        Long result = quotaResponseBuilderSpy.getAccountIdByAccountName("test", 1l, accountMock);
-
-        Assert.assertEquals(expected, result);
-    }
-
     @Test
     public void validatePositionOnCreatingNewQuotaTariffTestNullValueDoNothing() {
         quotaResponseBuilderSpy.validatePositionOnCreatingNewQuotaTariff(quotaTariffVoMock, null);