Autoscale VM load balancing rules improvements

Author: sureshanaparti

engine/schema/src/main/java/com/cloud/network/dao/LoadBalancerVMMapDao.java

@@ -42,5 +42,6 @@ public interface LoadBalancerVMMapDao extends GenericDao<LoadBalancerVMMapVO, Lo
     LoadBalancerVMMapVO findByLoadBalancerIdAndVmIdVmIp(long loadBalancerId, long instanceId, String instanceIp);
 
     void remove(long id, long instanceId, String instanceIp, Boolean revoke);
+
     int expungeByVmList(List<Long> vmIds, Long batchSize);
 }

engine/schema/src/main/java/com/cloud/network/dao/LoadBalancerVMMapDaoImpl.java

@@ -64,7 +64,6 @@ public void remove(long loadBalancerId, long instanceId, String instanceIp, Bool
         expunge(sc);
     }
 
-
     @Override
     public List<LoadBalancerVMMapVO> listByInstanceId(long instanceId) {
         SearchCriteria<LoadBalancerVMMapVO> sc = createSearchCriteria();

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

@@ -2002,7 +2002,7 @@ private UserVmVO startNewVM(long vmId) {
     }
 
     private boolean assignLBruleToNewVm(long vmId, AutoScaleVmGroupVO asGroup) {
-        List<Long> lstVmId = new ArrayList<Long>();
+        List<Long> vmIds = new ArrayList<>();
         long lbId = asGroup.getLoadBalancerId();
 
         List<LoadBalancerVMMapVO> lbVmMapVos = lbVmMapDao.listByLoadBalancerId(lbId);
@@ -2015,9 +2015,9 @@ private boolean assignLBruleToNewVm(long vmId, AutoScaleVmGroupVO asGroup) {
                 }
             }
         }
-        lstVmId.add(new Long(vmId));
+        vmIds.add(new Long(vmId));
         try {
-            return loadBalancingRulesService.assignToLoadBalancer(lbId, lstVmId, new HashMap<>(), true);
+            return loadBalancingRulesService.assignToLoadBalancer(lbId, vmIds, new HashMap<>(), true);
         } catch (CloudRuntimeException ex) {
             logger.warn("Caught exception: ", ex);
             return false;