use findByIdIncludingRemoved for volume retrieval in snapshot policy validation

Daman Arora · Daman Arora · commit 2afdd6b3a89a · 2026-01-20T10:30:28.000-05:00
diff --git a/server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java b/server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
@@ -1925,7 +1925,7 @@ public boolean deleteSnapshotPolicies(DeleteSnapshotPoliciesCmd cmd) {
             if (snapshotPolicyVO == null) {
                 throw new InvalidParameterValueException("Policy id given: " + policy + " does not exist");
             }
-            VolumeVO volume = _volsDao.findById(snapshotPolicyVO.getVolumeId());
+            VolumeVO volume = _volsDao.findByIdIncludingRemoved(snapshotPolicyVO.getVolumeId());
             if (volume == null) {
                 throw new InvalidParameterValueException("Policy id given: " + policy + " does not belong to a valid volume");
             }

Original file line number	Diff line number	Diff line change
`@@ -1925,7 +1925,7 @@ public boolean deleteSnapshotPolicies(DeleteSnapshotPoliciesCmd cmd) {`
`1925`	`1925`	`if (snapshotPolicyVO == null) {`
`1926`	`1926`	`throw new InvalidParameterValueException("Policy id given: " + policy + " does not exist");`
`1927`	`1927`	`}`
`1928`		`- VolumeVO volume = _volsDao.findById(snapshotPolicyVO.getVolumeId());`
	`1928`	`+ VolumeVO volume = _volsDao.findByIdIncludingRemoved(snapshotPolicyVO.getVolumeId());`
`1929`	`1929`	`if (volume == null) {`
`1930`	`1930`	`throw new InvalidParameterValueException("Policy id given: " + policy + " does not belong to a valid volume");`
`1931`	`1931`	`}`