Fix SystemVM template URL update for S3

Author: Daman Arora

engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java

@@ -959,6 +959,10 @@ public void registerTemplates(List<Pair<Hypervisor.HypervisorType, CPU.CPUArch>>
                     @Override
                     public void doInTransactionWithoutResult(final TransactionStatus status) {
                         List<Long> zoneIds = getEligibleZoneIds();
+                        if (zoneIds.isEmpty()) {
+                            updateTemplateUrlsForNonNfsStores(hypervisorsArchInUse);
+                            return;
+                        }
                         for (Long zoneId : zoneIds) {
                             String filePath = null;
                             try {
@@ -984,6 +988,20 @@ public void doInTransactionWithoutResult(final TransactionStatus status) {
         }
     }
 
+    private void updateTemplateUrlsForNonNfsStores(List<Pair<Hypervisor.HypervisorType, CPU.CPUArch>> hypervisorsInUse) {
+        for (Pair<Hypervisor.HypervisorType, CPU.CPUArch> hypervisorArch : hypervisorsInUse) {
+            MetadataTemplateDetails templateDetails = getMetadataTemplateDetails(hypervisorArch.first(), hypervisorArch.second());
+            if (templateDetails == null) {
+                continue;
+            }
+            VMTemplateVO templateVO = vmTemplateDao.findLatestTemplateByTypeAndHypervisorAndArch(
+                    templateDetails.getHypervisorType(), templateDetails.getArch(), Storage.TemplateType.SYSTEM);
+            if (templateVO != null) {
+                updateTemplateUrlChecksumAndGuestOsId(templateVO, templateDetails);
+            }
+        }
+    }
+
     private void updateRegisteredTemplateDetails(Long templateId, MetadataTemplateDetails templateDetails) {
         VMTemplateVO templateVO = vmTemplateDao.findById(templateId);
         templateVO.setTemplateType(Storage.TemplateType.SYSTEM);