Update responce handling

DaanHoogland · shwstppr · web-flow · commit 1563613e7cd5 · 2025-11-03T12:33:05.000+01:00
Co-authored-by: Abhishek Kumar &lt;abhishek.mrt22@gmail.com&gt;
diff --git a/plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/UnlinkDomainFromLdapCmd.java b/plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/UnlinkDomainFromLdapCmd.java
@@ -53,12 +53,11 @@ public Long getDomainId() {
     public void execute() throws ResourceUnavailableException, InsufficientCapacityException, ServerApiException, ConcurrentOperationException, ResourceAllocationException, NetworkRuleConflictException {
         boolean rc = _ldapManager.unlinkDomainFromLdap(this);
         SuccessResponse response = new SuccessResponse();
+        response.setSuccess(rc);
         if (rc) {
             response.setDisplayText("Domain unlinked from LDAP successfully");
-            response.setSuccess(true);
         } else {
             response.setDisplayText("Failed to unlink domain from LDAP");
-            response.setSuccess(false);
         }
         setResponseObject(response);
     }

Original file line number	Diff line number	Diff line change
`@@ -53,12 +53,11 @@ public Long getDomainId() {`
`53`	`53`	`public void execute() throws ResourceUnavailableException, InsufficientCapacityException, ServerApiException, ConcurrentOperationException, ResourceAllocationException, NetworkRuleConflictException {`
`54`	`54`	`boolean rc = _ldapManager.unlinkDomainFromLdap(this);`
`55`	`55`	`SuccessResponse response = new SuccessResponse();`
	`56`	`+ response.setSuccess(rc);`
`56`	`57`	`if (rc) {`
`57`	`58`	`response.setDisplayText("Domain unlinked from LDAP successfully");`
`58`		`- response.setSuccess(true);`
`59`	`59`	`} else {`
`60`	`60`	`response.setDisplayText("Failed to unlink domain from LDAP");`
`61`		`- response.setSuccess(false);`
`62`	`61`	`}`
`63`	`62`	`setResponseObject(response);`
`64`	`63`	`}`