Skip to content

[kafka-stream] test CI#38702

Closed
je-ik wants to merge 1 commit into
apache:feat/18479-kafka-streams-runner-skeleton-2from
je-ik:test-kafka-ci
Closed

[kafka-stream] test CI#38702
je-ik wants to merge 1 commit into
apache:feat/18479-kafka-streams-runner-skeleton-2from
je-ik:test-kafka-ci

Conversation

@je-ik
Copy link
Copy Markdown
Contributor

@je-ik je-ik commented May 27, 2026


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a minor, non-functional change to the KafkaStreamsRunner class, primarily serving as a test to verify the CI/CD pipeline configuration.

Highlights

  • Code Documentation: Added a trivial comment to the KafkaStreamsRunner class for testing purposes.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a trivial comment placeholder in the KafkaStreamsRunner class. The reviewer correctly pointed out that this temporary comment should be removed before merging to maintain code cleanliness.

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

// added trivial change
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This comment appears to be a temporary placeholder or trivial change for testing purposes. Please remove it before merging to keep the codebase clean.

@je-ik
Copy link
Copy Markdown
Contributor Author

je-ik commented May 27, 2026

Run Java_Kafka_Streams_Runner PreCommit

@je-ik je-ik force-pushed the feat/18479-kafka-streams-runner-skeleton-2 branch from 26ac09a to 085297f Compare May 27, 2026 06:18
@je-ik je-ik closed this May 27, 2026
@je-ik je-ik reopened this May 27, 2026
@je-ik je-ik force-pushed the feat/18479-kafka-streams-runner-skeleton-2 branch from 085297f to 84b5d12 Compare May 27, 2026 06:40
@je-ik je-ik closed this May 27, 2026
@je-ik je-ik reopened this May 27, 2026
@je-ik je-ik closed this May 27, 2026
@je-ik je-ik deleted the test-kafka-ci branch May 27, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant