From b36c27e210ca867eaf598a2221bfbf5cdde22489 Mon Sep 17 00:00:00 2001 From: Oscar Westra van Holthe - Kind Date: Fri, 30 May 2025 14:19:54 +0200 Subject: [PATCH 1/3] AVRO-4147: Mention ServiceLoader in SchemaFormatter javadoc --- .../avro/src/main/java/org/apache/avro/SchemaFormatter.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lang/java/avro/src/main/java/org/apache/avro/SchemaFormatter.java b/lang/java/avro/src/main/java/org/apache/avro/SchemaFormatter.java index 6303b01fb45..aaea648d955 100644 --- a/lang/java/avro/src/main/java/org/apache/avro/SchemaFormatter.java +++ b/lang/java/avro/src/main/java/org/apache/avro/SchemaFormatter.java @@ -55,7 +55,9 @@ * *

* Additional formats can be defined by implementing - * {@link SchemaFormatterFactory}. + * {@link SchemaFormatterFactory}. They are located using a + * {@link java.util.ServiceLoader} and must therefore be threadsafe. See the + * {@code ServiceLoader} class for details on loading your implementation. *

* * @see * @see IDL * Language + * @see java.util.ServiceLoader */ public interface SchemaFormatter { /** From 404e1858d5d62c206e129cdc0bbc502d8c19a441 Mon Sep 17 00:00:00 2001 From: Oscar Westra van Holthe - Kind Date: Fri, 30 May 2025 16:42:22 +0200 Subject: [PATCH 2/3] AVRO-4147: Improve javadoc from review comment --- .../avro/src/main/java/org/apache/avro/SchemaFormatter.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lang/java/avro/src/main/java/org/apache/avro/SchemaFormatter.java b/lang/java/avro/src/main/java/org/apache/avro/SchemaFormatter.java index aaea648d955..e212b3bfb60 100644 --- a/lang/java/avro/src/main/java/org/apache/avro/SchemaFormatter.java +++ b/lang/java/avro/src/main/java/org/apache/avro/SchemaFormatter.java @@ -56,8 +56,9 @@ *

* Additional formats can be defined by implementing * {@link SchemaFormatterFactory}. They are located using a - * {@link java.util.ServiceLoader} and must therefore be threadsafe. See the - * {@code ServiceLoader} class for details on loading your implementation. + * {@link java.util.ServiceLoader}, which loads them using the context ClassLoader + * when available, or the application ClassLoader when not. See the + * {@code ServiceLoader} class for more details΀. *

* * @see Date: Fri, 30 May 2025 17:14:38 +0200 Subject: [PATCH 3/3] AVRO-4147: spotless --- .../avro/src/main/java/org/apache/avro/SchemaFormatter.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lang/java/avro/src/main/java/org/apache/avro/SchemaFormatter.java b/lang/java/avro/src/main/java/org/apache/avro/SchemaFormatter.java index e212b3bfb60..dee5382a19f 100644 --- a/lang/java/avro/src/main/java/org/apache/avro/SchemaFormatter.java +++ b/lang/java/avro/src/main/java/org/apache/avro/SchemaFormatter.java @@ -56,8 +56,8 @@ *

* Additional formats can be defined by implementing * {@link SchemaFormatterFactory}. They are located using a - * {@link java.util.ServiceLoader}, which loads them using the context ClassLoader - * when available, or the application ClassLoader when not. See the + * {@link java.util.ServiceLoader}, which loads them using the context + * ClassLoader when available, or the application ClassLoader when not. See the * {@code ServiceLoader} class for more details΀. *

*