Skip to content

Commit 8b8b513

Browse files
committed
tweak signals
1 parent 77841dd commit 8b8b513

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

goldens/aria/accordion/index.api.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ export class AccordionTrigger implements OnInit {
6161
// (undocumented)
6262
ngOnInit(): void;
6363
readonly panel: _angular_core.InputSignal<AccordionPanel>;
64+
readonly panelId: _angular_core.Signal<string>;
6465
_pattern: AccordionTriggerPattern;
6566
toggle(): void;
6667
// (undocumented)

src/aria/private/accordion/accordion.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ export interface AccordionTriggerInputs
158158
/** A pattern controls the expansion state of an accordion. */
159159
export class AccordionTriggerPattern implements ListNavigationItem, ListFocusItem, ExpansionItem {
160160
/** A unique identifier for this trigger. */
161-
readonly id: SignalLike<string> = () => this.inputs.id();
161+
readonly id: SignalLike<string>; // set from inputs
162162

163163
/** A reference to the trigger element. */
164164
readonly element: SignalLike<HTMLElement> = () => this.inputs.element()!;
@@ -167,13 +167,13 @@ export class AccordionTriggerPattern implements ListNavigationItem, ListFocusIte
167167
readonly expandable: SignalLike<boolean> = () => true;
168168

169169
/** Whether the corresponding panel is expanded. */
170-
readonly expanded: WritableSignalLike<boolean>;
170+
readonly expanded: WritableSignalLike<boolean>; // set from inputs
171171

172172
/** Whether the trigger is active. */
173173
readonly active = computed(() => this.inputs.accordionGroup().inputs.activeItem() === this);
174174

175175
/** Id of the accordion panel controlled by the trigger. */
176-
readonly controls = computed(() => this.inputs.accordionPanelId());
176+
readonly controls: SignalLike<string>; // set from inputs
177177

178178
/** The tabindex of the trigger. */
179179
readonly tabIndex = computed(() =>
@@ -191,7 +191,9 @@ export class AccordionTriggerPattern implements ListNavigationItem, ListFocusIte
191191
);
192192

193193
constructor(readonly inputs: AccordionTriggerInputs) {
194+
this.id = inputs.id;
194195
this.expanded = inputs.expanded;
196+
this.controls = inputs.accordionPanelId;
195197
}
196198

197199
/** Opens the accordion panel. */

0 commit comments

Comments
 (0)