refactor(@angular/cli): update CLI package to be strict compliant

Author: alan-agius4

packages/angular/cli/commands/config-impl.ts

@@ -115,7 +115,7 @@ function getValueFromPath<T extends JsonArray | JsonObject>(
   const fragments = parseJsonPath(path);
 
   try {
-    return fragments.reduce((value: JsonValue, current: string | number) => {
+    return fragments.reduce((value: JsonValue | undefined, current: string | number) => {
       if (value == undefined || typeof value != 'object') {
         return undefined;
       } else if (typeof current == 'string' && !Array.isArray(value)) {
@@ -139,7 +139,7 @@ function setValueFromPath<T extends JsonArray | JsonObject>(
   const fragments = parseJsonPath(path);
 
   try {
-    return fragments.reduce((value: JsonValue, current: string | number, index: number) => {
+    return fragments.reduce((value: JsonValue | undefined, current: string | number, index: number) => {
       if (value == undefined || typeof value != 'object') {
         return undefined;
       } else if (typeof current == 'string' && !Array.isArray(value)) {

packages/angular/cli/commands/update-impl.ts

@@ -55,9 +55,8 @@ const disableVersionCheck =
 
 export class UpdateCommand extends Command<UpdateCommandSchema> {
   public readonly allowMissingWorkspace = true;
-
-  private workflow: NodeWorkflow;
-  private packageManager: PackageManager;
+  private workflow!: NodeWorkflow;
+  private packageManager = PackageManager.Npm;
 
   async initialize() {
     this.packageManager = await getPackageManager(this.workspace.root);

packages/angular/cli/commands/xi18n-impl.ts

@@ -12,7 +12,6 @@ import { Schema as Xi18nCommandSchema } from './xi18n';
 
 export class Xi18nCommand extends ArchitectCommand<Xi18nCommandSchema> {
   public readonly target = 'extract-i18n';
-  public readonly multiTarget: true;
 
   public async run(options: Xi18nCommandSchema & Arguments) {
     const version = process.version.substr(1).split('.');

packages/angular/cli/lib/cli/index.ts

@@ -42,17 +42,14 @@ export default async function(options: { testing?: boolean; cliArgs: string[] })
   });
 
   // Redirect console to logger
-  console.log = function() {
-    logger.info(format.apply(null, arguments));
+  console.info = console.log = function(...args) {
+    logger.info(format(...args));
   };
-  console.info = function() {
-    logger.info(format.apply(null, arguments));
+  console.warn = function(...args) {
+    logger.warn(format(...args));
   };
-  console.warn = function() {
-    logger.warn(format.apply(null, arguments));
-  };
-  console.error = function() {
-    logger.error(format.apply(null, arguments));
+  console.error = function(...args) {
+    logger.error(format(...args));
   };
 
   let projectDetails = getWorkspaceDetails();

packages/angular/cli/models/architect-command.ts

@@ -26,10 +26,10 @@ export interface ArchitectCommandOptions extends BaseCommandOptions {
 export abstract class ArchitectCommand<
   T extends ArchitectCommandOptions = ArchitectCommandOptions
 > extends Command<T> {
-  protected _architect: Architect;
-  protected _architectHost: WorkspaceNodeModulesArchitectHost;
-  protected _workspace: workspaces.WorkspaceDefinition;
-  protected _registry: json.schema.SchemaRegistry;
+  protected _architect!: Architect;
+  protected _architectHost!: WorkspaceNodeModulesArchitectHost;
+  protected _workspace!: workspaces.WorkspaceDefinition;
+  protected _registry!: json.schema.SchemaRegistry;
 
   // If this command supports running multiple targets.
   protected multiTarget = false;

packages/angular/cli/models/schematic-command.ts

@@ -75,8 +75,8 @@ export abstract class SchematicCommand<
 > extends Command<T> {
   readonly allowPrivateSchematics: boolean = false;
   private _host = new NodeJsSyncHost();
-  private _workspace: workspaces.WorkspaceDefinition;
-  protected _workflow: NodeWorkflow;
+  private _workspace: workspaces.WorkspaceDefinition | undefined;
+  protected _workflow!: NodeWorkflow;
 
   protected defaultCollectionName = '@schematics/angular';
   protected collectionName = this.defaultCollectionName;