refactor(@angular-devkit/core): adjust types to support strict mode

Author: clydin

packages/angular_devkit/core/src/logger/logger.ts

@@ -142,7 +142,10 @@ export class Logger extends Observable<LogEntry> implements LoggerApi {
   subscribe(_observerOrNext?: PartialObserver<LogEntry> | ((value: LogEntry) => void),
             _error?: (error: Error) => void,
             _complete?: () => void): Subscription {
-    return this._observable.subscribe.apply(this._observable, arguments as unknown);
+    return this._observable.subscribe.apply(
+      this._observable,
+      (arguments as unknown) as Parameters<Observable<LogEntry>['subscribe']>,
+    );
   }
   forEach(next: (value: LogEntry) => void, PromiseCtor?: typeof Promise): Promise<void> {
     return this._observable.forEach(next, PromiseCtor);

packages/angular_devkit/core/src/virtual-fs/path_spec.ts

@@ -8,6 +8,7 @@
 import {
   InvalidPathException,
   Path,
+  PathFragment,
   asWindowsPath,
   basename,
   dirname,
@@ -83,7 +84,7 @@ describe('path', () => {
   });
 
   describe('split', () => {
-    const tests = [
+    const tests: [string, string[]][] = [
       ['a', ['a']],
       ['/a/b', ['', 'a', 'b']],
       ['a/b', ['a', 'b']],
@@ -92,31 +93,29 @@ describe('path', () => {
       ['/', ['']],
     ];
 
-    for (const goldens of tests) {
-      const result = goldens.pop();
-      const args = goldens.map((x: string) => normalize(x)) as Path[];
+    for (const [input, result] of tests) {
+      const normalizedInput = normalize(input);
 
-      it(`(${JSON.stringify(args)}) == "${result}"`, () => {
-        expect(split.apply(null, args)).toEqual(result);
+      it(`(${JSON.stringify(normalizedInput)}) == "${result}"`, () => {
+        expect(split(normalizedInput)).toEqual(result as PathFragment[]);
       });
     }
   });
 
   describe('join', () => {
-    const tests = [
-      ['a', 'a'],
-      ['/a', '/b', '/a/b'],
-      ['/a', '/b', '/c', '/a/b/c'],
-      ['/a', 'b', 'c', '/a/b/c'],
-      ['a', 'b', 'c', 'a/b/c'],
+    const tests: [string[], string][] = [
+      [['a'], 'a'],
+      [['/a', '/b'], '/a/b'],
+      [['/a', '/b', '/c'], '/a/b/c'],
+      [['/a', 'b', 'c'], '/a/b/c'],
+      [['a', 'b', 'c'], 'a/b/c'],
     ];
 
-    for (const goldens of tests) {
-      const result = goldens.pop();
-      const args = goldens.map(x => normalize(x)) as Path[];
+    for (const [input, result] of tests) {
+      const args = input.map(x => normalize(x)) as [Path, ...Path[]];
 
       it(`(${JSON.stringify(args)}) == "${result}"`, () => {
-        expect(join.apply(null, args)).toBe(result);
+        expect(join(...args)).toBe(result);
       });
     }
   });