refactor(@angular/build): remove unnecessary source-map-support polyfill for Vitest browser coverage

Removes the injection of the source-map-support library in the Vitest builder. This workaround was previously required for correct stack traces in browser mode when coverage was enabled but is no longer necessary. This change simplifies the plugin logic and ensures source maps are consistently handled.

Author: clydin

packages/angular/build/src/builders/unit-test/runners/vitest/plugins.ts

@@ -114,15 +114,6 @@ export async function createVitestConfigPlugin(
         delete config.plugins;
       }
 
-      // Add browser source map support if coverage is enabled
-      if (
-        (browser || testConfig?.browser?.enabled) &&
-        (options.coverage.enabled || testConfig?.coverage?.enabled)
-      ) {
-        projectPlugins.unshift(createSourcemapSupportPlugin());
-        setupFiles.unshift('virtual:source-map-support');
-      }
-
       const projectResolver = createRequire(projectSourceRoot + '/').resolve;
 
       const projectDefaults: UserWorkspaceConfig = {
@@ -276,7 +267,7 @@ export function createVitestPlugins(pluginOptions: PluginOptions): VitestPlugins
 
           const map = sourceMapText ? JSON.parse(sourceMapText) : undefined;
           if (map) {
-            adjustSourcemapSources(map, !vitestConfig?.coverage?.enabled, workspaceRoot, id);
+            adjustSourcemapSources(map, true, workspaceRoot, id);
           }
 
           return {
@@ -343,36 +334,6 @@ function adjustSourcemapSources(
   }
 }
 
-function createSourcemapSupportPlugin(): VitestPlugins[0] {
-  return {
-    name: 'angular:source-map-support',
-    enforce: 'pre',
-    resolveId(source) {
-      if (source.includes('virtual:source-map-support')) {
-        return '\0source-map-support';
-      }
-    },
-    async load(id) {
-      if (id !== '\0source-map-support') {
-        return;
-      }
-
-      const packageResolve = createRequire(__filename).resolve;
-      const supportPath = packageResolve('source-map-support/browser-source-map-support.js');
-
-      const content = await readFile(supportPath, 'utf-8');
-
-      // The `source-map-support` library currently relies on `this` being defined in the global scope.
-      // However, when running in an ESM environment, `this` is undefined.
-      // To workaround this, we patch the library to use `globalThis` instead of `this`.
-      return (
-        content.replaceAll(/this\.(define|sourceMapSupport|base64js)/g, 'globalThis.$1') +
-        '\n;globalThis.sourceMapSupport.install();'
-      );
-    },
-  };
-}
-
 async function generateCoverageOption(
   optionsCoverage: NormalizedUnitTestBuilderOptions['coverage'],
   configCoverage: VitestCoverageOption | undefined,

tests/e2e/tests/vitest/browser-sourcemaps.ts

@@ -37,4 +37,20 @@ export default async function (): Promise<void> {
       'Expected stack trace to point to the source file.',
     );
   }
+
+  // Again but with coverage
+  try {
+    await noSilentNg('test', '--no-watch', '--coverage', '--browsers', 'chromiumHeadless');
+    throw new Error('Expected "ng test" to fail.');
+  } catch (error: any) {
+    const stdout = stripVTControlCharacters(error.stdout || error.message);
+    // We expect the failure from failing.spec.ts
+    assert.match(stdout, /1 failed/, 'Expected 1 test to fail.');
+    // Check that the stack trace points to the correct file
+    assert.match(
+      stdout,
+      /\bsrc[\/\\]app[\/\\]failing\.spec\.ts:4:\d+/,
+      'Expected stack trace to point to the source file.',
+    );
+  }
 }