refactor(@angular-devkit/build-angular): remove target parameter from BuildBrowserFeatures ctor

Author: alan-agius4

packages/angular_devkit/build_angular/src/utils/build-browser-features.ts

@@ -11,23 +11,22 @@ import { feature, features } from 'caniuse-lite';
 import * as ts from 'typescript';
 
 export class BuildBrowserFeatures {
-  private readonly _es6TargetOrLater: boolean;
   readonly supportedBrowsers: string[];
 
   constructor(
     private projectRoot: string,
-    private scriptTarget: ts.ScriptTarget,
   ) {
     this.supportedBrowsers = browserslist(undefined, { path: this.projectRoot });
-    this._es6TargetOrLater = this.scriptTarget > ts.ScriptTarget.ES5;
   }
 
   /**
    * True, when one or more browsers requires ES5
    * support and the scirpt target is ES2015 or greater.
    */
-  isDifferentialLoadingNeeded(): boolean {
-    return this._es6TargetOrLater && this.isEs5SupportNeeded();
+  isDifferentialLoadingNeeded(scriptTarget: ts.ScriptTarget): boolean {
+    const es6TargetOrLater = scriptTarget > ts.ScriptTarget.ES5;
+
+    return es6TargetOrLater && this.isEs5SupportNeeded();
   }
 
   /**

packages/angular_devkit/build_angular/src/utils/build-browser-features_spec.ts

@@ -30,47 +30,35 @@ describe('BuildBrowserFeatures', () => {
         '.browserslistrc': 'IE 9-11',
       });
 
-      const buildBrowserFeatures = new BuildBrowserFeatures(
-        workspaceRootSysPath,
-        ScriptTarget.ES2015,
-      );
-      expect(buildBrowserFeatures.isDifferentialLoadingNeeded()).toBe(true);
+      const buildBrowserFeatures = new BuildBrowserFeatures(workspaceRootSysPath);
+      expect(buildBrowserFeatures.isDifferentialLoadingNeeded(ScriptTarget.ES2015)).toBe(true);
     });
 
     it('should be false for Chrome and ES2015', () => {
       host.writeMultipleFiles({
         '.browserslistrc': 'last 1 chrome version',
       });
 
-      const buildBrowserFeatures = new BuildBrowserFeatures(
-        workspaceRootSysPath,
-        ScriptTarget.ES2015,
-      );
-      expect(buildBrowserFeatures.isDifferentialLoadingNeeded()).toBe(false);
+      const buildBrowserFeatures = new BuildBrowserFeatures(workspaceRootSysPath);
+      expect(buildBrowserFeatures.isDifferentialLoadingNeeded(ScriptTarget.ES2015)).toBe(false);
     });
 
     it('detects no need for differential loading for target is ES5', () => {
       host.writeMultipleFiles({
         '.browserslistrc': 'last 1 chrome version',
       });
 
-      const buildBrowserFeatures = new BuildBrowserFeatures(
-        workspaceRootSysPath,
-        ScriptTarget.ES5,
-      );
-      expect(buildBrowserFeatures.isDifferentialLoadingNeeded()).toBe(false);
+      const buildBrowserFeatures = new BuildBrowserFeatures(workspaceRootSysPath);
+      expect(buildBrowserFeatures.isDifferentialLoadingNeeded(ScriptTarget.ES5)).toBe(false);
     });
 
     it('should be false for Safari 10.1 when target is ES2015', () => {
       host.writeMultipleFiles({
         '.browserslistrc': 'Safari 10.1',
       });
 
-      const buildBrowserFeatures = new BuildBrowserFeatures(
-        workspaceRootSysPath,
-        ScriptTarget.ES2015,
-      );
-      expect(buildBrowserFeatures.isDifferentialLoadingNeeded()).toBe(false);
+      const buildBrowserFeatures = new BuildBrowserFeatures(workspaceRootSysPath);
+      expect(buildBrowserFeatures.isDifferentialLoadingNeeded(ScriptTarget.ES2015)).toBe(false);
     });
   });
 
@@ -80,10 +68,7 @@ describe('BuildBrowserFeatures', () => {
         '.browserslistrc': 'Safari 10.1',
       });
 
-      const buildBrowserFeatures = new BuildBrowserFeatures(
-        workspaceRootSysPath,
-        ScriptTarget.ES2015,
-      );
+      const buildBrowserFeatures = new BuildBrowserFeatures(workspaceRootSysPath);
       expect(buildBrowserFeatures.isFeatureSupported('es6-module')).toBe(true);
     });
 
@@ -92,10 +77,7 @@ describe('BuildBrowserFeatures', () => {
         '.browserslistrc': 'IE 9',
       });
 
-      const buildBrowserFeatures = new BuildBrowserFeatures(
-        workspaceRootSysPath,
-        ScriptTarget.ES2015,
-      );
+      const buildBrowserFeatures = new BuildBrowserFeatures(workspaceRootSysPath);
       expect(buildBrowserFeatures.isFeatureSupported('es6-module')).toBe(false);
     });
 
@@ -104,10 +86,7 @@ describe('BuildBrowserFeatures', () => {
         '.browserslistrc': 'last 1 chrome version',
       });
 
-      const buildBrowserFeatures = new BuildBrowserFeatures(
-        workspaceRootSysPath,
-        ScriptTarget.ES2015,
-      );
+      const buildBrowserFeatures = new BuildBrowserFeatures(workspaceRootSysPath);
       expect(buildBrowserFeatures.isFeatureSupported('es6-module')).toBe(true);
     });
 
@@ -116,10 +95,7 @@ describe('BuildBrowserFeatures', () => {
         '.browserslistrc': 'Edge 18',
       });
 
-      const buildBrowserFeatures = new BuildBrowserFeatures(
-        workspaceRootSysPath,
-        ScriptTarget.ES2015,
-      );
+      const buildBrowserFeatures = new BuildBrowserFeatures(workspaceRootSysPath);
       expect(buildBrowserFeatures.isFeatureSupported('es6-module')).toBe(true);
     });
   });