refactor(@angular/cli): remove deprecated typescriptMismatch

BREAKING CHANGE:
Removed deprecated `typescriptMismatch` warning option. Users will be migrated off this option automatically. Users wishing to disable TypeScript version checks should use the Angular compiler option `disableTypeScriptVersionCheck`, see https://angular.io/guide/angular-compiler-options#disabletypescriptversioncheck for more information.

Author: alan-agius4

packages/angular/cli/commands/config-impl.ts

@@ -243,15 +243,6 @@ export class ConfigCommand extends Command<ConfigCommandSchema> {
   private get(config: experimental.workspace.WorkspaceSchema, options: ConfigCommandSchema) {
     let value;
     if (options.jsonPath) {
-      if (options.jsonPath === 'cli.warnings.typescriptMismatch') {
-        // NOTE: Remove this in 9.0.
-        this.logger.warn('The "typescriptMismatch" warning has been removed in 8.0.');
-        // Since there is no actual warning, this value is always false.
-        this.logger.info('false');
-
-        return 0;
-      }
-
       value = getValueFromPath((config as {}) as JsonObject, options.jsonPath);
     } else {
       value = config;
@@ -275,13 +266,6 @@ export class ConfigCommand extends Command<ConfigCommandSchema> {
       throw new Error('Invalid Path.');
     }
 
-    if (options.jsonPath === 'cli.warnings.typescriptMismatch') {
-      // NOTE: Remove this in 9.0.
-      this.logger.warn('The "typescriptMismatch" warning has been removed in 8.0.');
-
-      return 0;
-    }
-
     if (
       options.global &&
       !options.jsonPath.startsWith('schematics.') &&

packages/angular/cli/lib/config/schema.json

@@ -58,11 +58,6 @@
             "versionMismatch": {
               "description": "Show a warning when the global version is newer than the local one.",
               "type": "boolean"
-            },
-            "typescriptMismatch": {
-              "description": "Show a warning when the TypeScript version is incompatible.",
-              "type": "boolean",
-              "x-deprecated": true
             }
           }
         },
@@ -1783,16 +1778,6 @@
                 }
               ]
             },
-            "vendorChunk": {
-              "type": "boolean",
-              "description": "Use a separate bundle containing only vendor libraries.",
-              "default": true
-            },
-            "commonChunk": {
-              "type": "boolean",
-              "description": "Use a separate bundle containing code used across multiple bundles.",
-              "default": true
-            },
             "verbose": {
               "type": "boolean",
               "description": "Adds more details to output logging.",

packages/angular/cli/models/command-runner.ts

@@ -15,7 +15,6 @@ import {
   strings,
   tags,
 } from '@angular-devkit/core';
-import * as debug from 'debug';
 import { readFileSync } from 'fs';
 import { join, resolve } from 'path';
 import { parseJsonSchemaToCommandDescription } from '../utilities/json-schema';
@@ -30,8 +29,6 @@ import { Command } from './command';
 import { CommandDescription, CommandWorkspace } from './interface';
 import * as parser from './parser';
 
-const analyticsDebug = debug('ng:analytics:commands');
-
 // NOTE: Update commands.json if changing this.  It's still deep imported in one CI validation
 const standardCommands = {
   'add': '../commands/add.json',

packages/schematics/angular/migrations/update-10/update-angular-config.ts

@@ -6,14 +6,20 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import { workspaces } from '@angular-devkit/core';
+import { JsonObject, JsonValue, isJsonObject, workspaces } from '@angular-devkit/core';
 import { Rule } from '@angular-devkit/schematics';
 import { updateWorkspace } from '../../utility/workspace';
 import { Builders, ProjectType } from '../../utility/workspace-models';
 
 export default function (): Rule {
   return updateWorkspace(workspace => {
+    // Remove deprecated CLI root level options
+    removeDeprecatedCLIOptions(workspace.extensions);
+
     for (const [, project] of workspace.projects) {
+      // Project level
+      removeDeprecatedCLIOptions(project.extensions);
+
       if (project.extensions.projectType !== ProjectType.Application) {
         // Only interested in application projects since these changes only effects application builders
         continue;
@@ -104,3 +110,13 @@ function updateVendorSourceMap(options: TargetOptions): TargetOptions {
     vendorSourceMap: undefined,
   };
 }
+
+function removeDeprecatedCLIOptions(extensions: Record<string, JsonValue | undefined>) {
+  const cliOptions = extensions?.cli;
+  if (cliOptions && isJsonObject(cliOptions) && isJsonObject(cliOptions.warnings)) {
+    (cliOptions.warnings as Partial<JsonObject>) = {
+      ...cliOptions.warnings,
+      typescriptMismatch: undefined,
+    };
+  }
+}

packages/schematics/angular/migrations/update-10/update-angular-config_spec.ts

@@ -17,8 +17,20 @@ function getBuildTarget(tree: UnitTestTree): BuilderTarget<Builders.Browser, Jso
 function createWorkSpaceConfig(tree: UnitTestTree) {
   const angularConfig: WorkspaceSchema = {
     version: 1,
+    cli: {
+      warnings: {
+        versionMismatch: false,
+        typescriptMismatch: true,
+      },
+    },
     projects: {
       app: {
+        cli: {
+          warnings: {
+            versionMismatch: false,
+            typescriptMismatch: true,
+          },
+        },
         root: '',
         sourceRoot: 'src',
         projectType: ProjectType.Application,
@@ -120,4 +132,18 @@ describe(`Migration to update 'angular.json'`, () => {
       styles: false,
     });
   });
+
+  it(`should remove root level 'typescriptMismatch'`, async () => {
+    const newTree = await schematicRunner.runSchematicAsync(schematicName, {}, tree).toPromise();
+    const config = JSON.parse(newTree.readContent('/angular.json')).cli.warnings;
+    expect(config.typescriptMismatch).toBeUndefined();
+    expect(config.versionMismatch).toBeFalse();
+  });
+
+  it(`should remove project level 'typescriptMismatch'`, async () => {
+    const newTree = await schematicRunner.runSchematicAsync(schematicName, {}, tree).toPromise();
+    const config = JSON.parse(newTree.readContent('/angular.json')).projects.app.cli.warnings;
+    expect(config.typescriptMismatch).toBeUndefined();
+    expect(config.versionMismatch).toBeFalse();
+  });
 });

packages/schematics/angular/utility/config.ts

@@ -455,26 +455,7 @@ export interface CliConfig {
    * Allow people to disable console warnings.
    */
   warnings?: {
-      /**
-       * Show a warning when the user enabled the --hmr option.
-       */
-      hmrWarning?: boolean;
-      /**
-       * Show a warning when the node version is incompatible.
-       */
-      nodeDeprecation?: boolean;
-      /**
-       * Show a warning when the user installed angular-cli.
-       */
-      packageDeprecation?: boolean;
-      /**
-       * Show a warning when the global version is newer than the local one.
-       */
       versionMismatch?: boolean;
-      /**
-       * Show a warning when the TypeScript version is incompatible
-       */
-      typescriptMismatch?: boolean;
   };
 }