style: remove redundant max-line-length disables and fix other lint issues

Author: alan-agius4

packages/angular/cli/lib/cli/index.ts

@@ -72,7 +72,7 @@ export default async function(options: { testing?: boolean; cliArgs: string[] })
 
         logger.fatal(
           `An unhandled exception occurred: ${err.message}\n` +
-            `See "${logPath}" for further details.`
+            `See "${logPath}" for further details.`,
         );
       } catch (e) {
         logger.fatal(

packages/angular/cli/utilities/config.ts

@@ -86,8 +86,8 @@ export function getWorkspace(
   if (error) {
     throw new Error(
       `Workspace config file cannot le loaded: ${configPath}`
-      + `\n${error instanceof Error ? error.message : error}`
-    )
+      + `\n${error instanceof Error ? error.message : error}`,
+    );
   }
 
   cachedWorkspaces.set(level, workspace);

packages/angular/pwa/pwa/index_spec.ts

@@ -9,8 +9,6 @@ import { SchematicTestRunner, UnitTestTree } from '@angular-devkit/schematics/te
 import * as path from 'path';
 import { Schema as PwaOptions } from './schema';
 
-
-// tslint:disable:max-line-length
 describe('PWA Schematic', () => {
   const schematicRunner = new SchematicTestRunner(
     '@angular/pwa',

packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/utils.ts

@@ -21,7 +21,6 @@ export interface HashFormat {
 }
 
 export function getOutputHashFormat(option: string, length = 20): HashFormat {
-  /* tslint:disable:max-line-length */
   const hashFormats: { [option: string]: HashFormat } = {
     none: { chunk: '', extract: '', file: '', script: '' },
     media: { chunk: '', extract: '', file: `.[hash:${length}]`, script: '' },
@@ -38,7 +37,6 @@ export function getOutputHashFormat(option: string, length = 20): HashFormat {
       script: `.[hash:${length}]`,
     },
   };
-  /* tslint:enable:max-line-length */
   return hashFormats[option] || hashFormats['none'];
 }
 

packages/angular_devkit/build_optimizer/src/build-optimizer/build-optimizer_spec.ts

@@ -54,7 +54,6 @@ describe('build-optimizer', () => {
         }());
         var RenderType_MdOption = ɵcrt({ encapsulation: 2, styles: styles_MdOption});
       `;
-      // tslint:disable:max-line-length
       const output = tags.oneLine`
         import { __extends } from "tslib";
         ${imports}

packages/angular_devkit/build_optimizer/src/build-optimizer/webpack-plugin.ts

@@ -10,8 +10,8 @@ import { Compiler } from 'webpack';  // tslint:disable-line:no-implicit-dependen
 
 export class BuildOptimizerWebpackPlugin {
   apply(compiler: Compiler) {
-    compiler.hooks.normalModuleFactory.tap("BuildOptimizerWebpackPlugin", nmf => {
-      nmf.hooks.module.tap("BuildOptimizerWebpackPlugin", (module, data) => {
+    compiler.hooks.normalModuleFactory.tap('BuildOptimizerWebpackPlugin', nmf => {
+      nmf.hooks.module.tap('BuildOptimizerWebpackPlugin', (module, data) => {
         const resolveData = data.resourceResolveData;
         if (resolveData && resolveData.descriptionFileData) {
           // Only TS packages should use Build Optimizer.

packages/angular_devkit/build_optimizer/src/transforms/import-tslib_spec.ts

@@ -32,7 +32,6 @@ describe('import-tslib', () => {
   });
 
   it('replaces wrapped __extends', () => {
-    // tslint:disable:max-line-length
     const input = tags.stripIndent`
     export default function appGlobal() {
         var __extends = (this && this.__extends) || function (d, b) {
@@ -61,7 +60,6 @@ describe('import-tslib', () => {
           return c > 3 && r && Object.defineProperty(target, key, r), r;
       };
     `;
-    // tslint:enable:max-line-length
     const output = tags.stripIndent`
       import { __decorate } from "tslib";
     `;
@@ -71,13 +69,11 @@ describe('import-tslib', () => {
   });
 
   it('replaces __metadata', () => {
-    // tslint:disable:max-line-length
     const input = tags.stripIndent`
       var __metadata = (this && this.__metadata) || function (k, v) {
           if (typeof Reflect === "object" && typeof Reflect.metadata === "function") return Reflect.metadata(k, v);
       };
     `;
-    // tslint:enable:max-line-length
     const output = tags.stripIndent`
       import { __metadata } from "tslib";
     `;

packages/angular_devkit/build_optimizer/src/transforms/wrap-enums.ts

@@ -262,7 +262,7 @@ function findTs2_3EnumIife(
       || !ts.isBinaryExpression(statement.expression)
       || !ts.isElementAccessExpression(statement.expression.left)
     ) {
-      return null
+      return null;
     }
 
     const leftExpression = statement.expression.left.expression;

packages/angular_devkit/schematics/tools/workflow/node-workflow.ts

@@ -34,7 +34,7 @@ export class NodeWorkflow extends workflow.BaseWorkflow {
 
       force: options.force,
       dryRun: options.dryRun,
-      registry: options.registry
+      registry: options.registry,
     });
 
     engineHost.registerTaskExecutor(

packages/angular_devkit/schematics_cli/bin/schematics.ts

@@ -24,7 +24,7 @@ import {
   DryRunEvent,
   SchematicEngine,
   UnsuccessfulWorkflowExecution,
-  formats
+  formats,
 } from '@angular-devkit/schematics';
 import { NodeModulesEngineHost, NodeWorkflow, validateOptionsWithSchema } from '@angular-devkit/schematics/tools';
 import * as inquirer from 'inquirer';