Commit edfd6d7
committed
fix: remove hard-coded paths from test-prerequisites, document environment assumptions
CRITICAL BUG FIX (A1):
- test-prerequisites.spec.ts used hard-coded /Users/johanneshoppe/... paths
- Tests would fail on CI and all other machines
- This invalidated "production-ready" status
Changes to test-prerequisites.spec.ts:
1. Added const projectRoot = process.cwd() for dynamic path resolution
2. Replaced all hard-coded cwd: '/Users/johanneshoppe/...' with cwd: projectRoot
3. Updated error messages to use ${projectRoot} template strings
4. Lines changed: 65, 67, 77, 85, 113, 115
Changes to TEST_COVERAGE_PLAN.md:
1. B1 - Added "Test Environment Requirements" section (lines 252-272)
- Documents git availability requirements
- Documents working directory assumptions (process.cwd())
- Documents real git integration test dependencies
- Provides CI setup guidance
2. B2 - Added "Known Upgrade Tripwires" section (lines 216-240)
- Documents intentionally pinned gh-pages v3.2.3 behaviors
- Lists getRemoteUrl error message assertions
- Lists dotfiles behavior assertions
- Lists PublishOptions mapping tests
- Explains these are FEATURES for upgrade verification
Test results:
- test-prerequisites.spec.ts: All 3 tests pass ✅
- Full suite: All 380 tests pass ✅
- Tests now portable across all machines with proper git setup
Honest status update:
- Previous claim: "100% complete, production-ready, zero gaps"
- Reality: Critical portability bug made tests fail outside original machine
- Current: Upgrade-ready with strong v3.2.3 baseline and portable tests1 parent d7a0e1c commit edfd6d7
2 files changed
+55
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
216 | 242 | | |
217 | 243 | | |
218 | 244 | | |
| |||
249 | 275 | | |
250 | 276 | | |
251 | 277 | | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
252 | 301 | | |
253 | 302 | | |
254 | 303 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
| |||
62 | 64 | | |
63 | 65 | | |
64 | 66 | | |
65 | | - | |
| 67 | + | |
66 | 68 | | |
67 | 69 | | |
68 | 70 | | |
| |||
74 | 76 | | |
75 | 77 | | |
76 | 78 | | |
77 | | - | |
| 79 | + | |
78 | 80 | | |
79 | 81 | | |
80 | 82 | | |
81 | 83 | | |
82 | 84 | | |
83 | | - | |
| 85 | + | |
84 | 86 | | |
85 | 87 | | |
86 | 88 | | |
| |||
110 | 112 | | |
111 | 113 | | |
112 | 114 | | |
113 | | - | |
| 115 | + | |
114 | 116 | | |
115 | 117 | | |
116 | 118 | | |
| |||
0 commit comments