Skip to content

Commit f24fb4e

Browse files
crisbetocrisbeto
authored
refactor(multiple): strongly type SimpleChanges (angular#32871)
A few versions ago Angular added strong typing for the `SimpleChanges` object. These changes update our usages to be type safe.
1 parent c7cc0be commit f24fb4e

46 files changed

Lines changed: 99 additions & 69 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎goldens/cdk/a11y/index.api.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ export class CdkTrapFocus implements OnDestroy, AfterContentInit, OnChanges, DoC
114114
// (undocumented)
115115
ngDoCheck(): void;
116116
// (undocumented)
117-
ngOnChanges(changes: SimpleChanges): void;
117+
ngOnChanges(changes: SimpleChanges<this>): void;
118118
// (undocumented)
119119
ngOnDestroy(): void;
120120
// (undocumented)

‎goldens/cdk/accordion/index.api.md‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,12 @@ export class CdkAccordion implements OnDestroy, OnChanges {
2424
// (undocumented)
2525
static ngAcceptInputType_multi: unknown;
2626
// (undocumented)
27-
ngOnChanges(changes: SimpleChanges): void;
27+
ngOnChanges(changes: SimpleChanges<this>): void;
2828
// (undocumented)
2929
ngOnDestroy(): void;
3030
openAll(): void;
3131
readonly _openCloseAllActions: Subject<boolean>;
32-
readonly _stateChanges: Subject<{
33-
[propName: string]: i0.SimpleChange<any>;
34-
}>;
32+
readonly _stateChanges: Subject<SimpleChanges<this>>;
3533
// (undocumented)
3634
static ɵdir: i0.ɵɵDirectiveDeclaration<CdkAccordion, "cdk-accordion, [cdkAccordion]", ["cdkAccordion"], { "multi": { "alias": "multi"; "required": false; }; }, {}, never, never, true, never>;
3735
// (undocumented)

‎goldens/cdk/drag-drop/index.api.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export class CdkDrag<T = any> implements AfterViewInit, OnChanges, OnDestroy {
7676
// (undocumented)
7777
ngAfterViewInit(): void;
7878
// (undocumented)
79-
ngOnChanges(changes: SimpleChanges): void;
79+
ngOnChanges(changes: SimpleChanges<this>): void;
8080
// (undocumented)
8181
ngOnDestroy(): void;
8282
previewClass: string | string[];

‎goldens/cdk/menu/index.api.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ export class CdkMenuTrigger extends CdkMenuTriggerBase implements OnChanges, OnD
217217
getMenu(): Menu | undefined;
218218
_handleClick(): void;
219219
// (undocumented)
220-
ngOnChanges(changes: SimpleChanges): void;
220+
ngOnChanges(changes: SimpleChanges<this>): void;
221221
// (undocumented)
222222
ngOnDestroy(): void;
223223
open(): void;

‎goldens/cdk/overlay/index.api.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
7878
// (undocumented)
7979
static ngAcceptInputType_push: unknown;
8080
// (undocumented)
81-
ngOnChanges(changes: SimpleChanges): void;
81+
ngOnChanges(changes: SimpleChanges<this>): void;
8282
// (undocumented)
8383
ngOnDestroy(): void;
8484
get offsetX(): number;

‎goldens/cdk/table/index.api.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export abstract class BaseRowDef implements OnChanges {
4646
extractCellTemplate(column: CdkColumnDef): TemplateRef<any>;
4747
getColumnsDiff(): IterableChanges<any> | null;
4848
// (undocumented)
49-
ngOnChanges(changes: SimpleChanges): void;
49+
ngOnChanges(changes: SimpleChanges<this>): void;
5050
// (undocumented)
5151
template: TemplateRef<any>;
5252
// (undocumented)
@@ -187,7 +187,7 @@ export class CdkFooterRowDef extends BaseRowDef implements CanStick, OnChanges {
187187
// (undocumented)
188188
static ngAcceptInputType_sticky: unknown;
189189
// (undocumented)
190-
ngOnChanges(changes: SimpleChanges): void;
190+
ngOnChanges(changes: SimpleChanges<this>): void;
191191
resetStickyChanged(): void;
192192
get sticky(): boolean;
193193
set sticky(value: boolean);
@@ -233,7 +233,7 @@ export class CdkHeaderRowDef extends BaseRowDef implements CanStick, OnChanges {
233233
// (undocumented)
234234
static ngAcceptInputType_sticky: unknown;
235235
// (undocumented)
236-
ngOnChanges(changes: SimpleChanges): void;
236+
ngOnChanges(changes: SimpleChanges<this>): void;
237237
resetStickyChanged(): void;
238238
get sticky(): boolean;
239239
set sticky(value: boolean);

‎goldens/google-maps/index.api.md‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ export class DeprecatedMapMarkerClusterer implements OnInit, AfterContentInit, O
210210
// (undocumented)
211211
ngAfterContentInit(): void;
212212
// (undocumented)
213-
ngOnChanges(changes: SimpleChanges): void;
213+
ngOnChanges(changes: SimpleChanges<this>): void;
214214
// (undocumented)
215215
ngOnDestroy(): void;
216216
// (undocumented)
@@ -271,7 +271,7 @@ export class GoogleMap implements OnChanges, OnInit, OnDestroy {
271271
readonly maptypeidChanged: Observable<void>;
272272
get mapTypes(): google.maps.MapTypeRegistry;
273273
// (undocumented)
274-
ngOnChanges(changes: SimpleChanges): void;
274+
ngOnChanges(changes: SimpleChanges<this>): void;
275275
// (undocumented)
276276
ngOnDestroy(): void;
277277
// (undocumented)
@@ -328,7 +328,7 @@ export class MapAdvancedMarker implements OnInit, OnChanges, OnDestroy, MapAncho
328328
readonly mapRightclick: Observable<MouseEvent>;
329329
readonly markerInitialized: EventEmitter<google.maps.marker.AdvancedMarkerElement>;
330330
// (undocumented)
331-
ngOnChanges(changes: SimpleChanges): void;
331+
ngOnChanges(changes: SimpleChanges<this>): void;
332332
// (undocumented)
333333
ngOnDestroy(): void;
334334
// (undocumented)
@@ -457,7 +457,7 @@ export class MapDirectionsRenderer implements OnInit, OnChanges, OnDestroy {
457457
getPanel(): Node | null;
458458
getRouteIndex(): number;
459459
// (undocumented)
460-
ngOnChanges(changes: SimpleChanges): void;
460+
ngOnChanges(changes: SimpleChanges<this>): void;
461461
// (undocumented)
462462
ngOnDestroy(): void;
463463
// (undocumented)
@@ -546,7 +546,7 @@ export class MapHeatmapLayer implements OnInit, OnChanges, OnDestroy {
546546
heatmap?: google.maps.visualization.HeatmapLayer;
547547
readonly heatmapInitialized: EventEmitter<google.maps.visualization.HeatmapLayer>;
548548
// (undocumented)
549-
ngOnChanges(changes: SimpleChanges): void;
549+
ngOnChanges(changes: SimpleChanges<this>): void;
550550
// (undocumented)
551551
ngOnDestroy(): void;
552552
// (undocumented)
@@ -654,7 +654,7 @@ export class MapMarker implements OnInit, OnChanges, OnDestroy, MapAnchorPoint,
654654
marker?: google.maps.Marker;
655655
readonly markerInitialized: EventEmitter<google.maps.Marker>;
656656
// (undocumented)
657-
ngOnChanges(changes: SimpleChanges): void;
657+
ngOnChanges(changes: SimpleChanges<this>): void;
658658
// (undocumented)
659659
ngOnDestroy(): void;
660660
// (undocumented)
@@ -686,7 +686,7 @@ export class MapMarkerClusterer implements OnInit, OnChanges, OnDestroy {
686686
// (undocumented)
687687
_markers: QueryList<MarkerDirective>;
688688
// (undocumented)
689-
ngOnChanges(changes: SimpleChanges): Promise<void>;
689+
ngOnChanges(changes: SimpleChanges<this>): Promise<void>;
690690
// (undocumented)
691691
ngOnDestroy(): void;
692692
// (undocumented)

‎goldens/material/autocomplete/index.api.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ export class MatAutocompleteTrigger implements ControlValueAccessor, AfterViewIn
176176
// (undocumented)
177177
ngAfterViewInit(): void;
178178
// (undocumented)
179-
ngOnChanges(changes: SimpleChanges): void;
179+
ngOnChanges(changes: SimpleChanges<this>): void;
180180
// (undocumented)
181181
ngOnDestroy(): void;
182182
_onChange: (value: any) => void;

‎goldens/material/checkbox/index.api.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export class MatCheckbox implements AfterViewInit, OnChanges, ControlValueAccess
8585
// (undocumented)
8686
ngAfterViewInit(): void;
8787
// (undocumented)
88-
ngOnChanges(changes: SimpleChanges): void;
88+
ngOnChanges(changes: SimpleChanges<this>): void;
8989
// (undocumented)
9090
_onBlur(): void;
9191
// (undocumented)

‎goldens/material/datepicker/index.api.md‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ export class MatCalendar<D> implements AfterContentInit, AfterViewChecked, OnDes
130130
// (undocumented)
131131
ngAfterViewChecked(): void;
132132
// (undocumented)
133-
ngOnChanges(changes: SimpleChanges): void;
133+
ngOnChanges(changes: SimpleChanges<this>): void;
134134
// (undocumented)
135135
ngOnDestroy(): void;
136136
get selected(): DateRange<D> | D | null;
@@ -200,7 +200,7 @@ export class MatCalendarBody<D = any> implements OnChanges, OnDestroy, AfterView
200200
// (undocumented)
201201
ngAfterViewChecked(): void;
202202
// (undocumented)
203-
ngOnChanges(changes: SimpleChanges): void;
203+
ngOnChanges(changes: SimpleChanges<this>): void;
204204
// (undocumented)
205205
ngOnDestroy(): void;
206206
numCols: number;
@@ -504,7 +504,7 @@ export class MatDatepickerToggle<D> implements AfterContentInit, OnChanges, OnDe
504504
// (undocumented)
505505
ngAfterContentInit(): void;
506506
// (undocumented)
507-
ngOnChanges(changes: SimpleChanges): void;
507+
ngOnChanges(changes: SimpleChanges<this>): void;
508508
// (undocumented)
509509
ngOnDestroy(): void;
510510
// (undocumented)
@@ -569,7 +569,7 @@ export class MatDateRangeInput<D> implements MatFormFieldControl<DateRange<D>>,
569569
ngAfterContentInit(): void;
570570
ngControl: NgControl | null;
571571
// (undocumented)
572-
ngOnChanges(changes: SimpleChanges): void;
572+
ngOnChanges(changes: SimpleChanges<this>): void;
573573
// (undocumented)
574574
ngOnDestroy(): void;
575575
onContainerClick(): void;
@@ -693,7 +693,7 @@ export class MatMonthView<D> implements AfterContentInit, OnChanges, OnDestroy {
693693
// (undocumented)
694694
ngAfterContentInit(): void;
695695
// (undocumented)
696-
ngOnChanges(changes: SimpleChanges): void;
696+
ngOnChanges(changes: SimpleChanges<this>): void;
697697
// (undocumented)
698698
ngOnDestroy(): void;
699699
_previewChanged({ event, value: cell }: MatCalendarUserEvent<MatCalendarCell<D> | null>): void;

0 commit comments

Comments
 (0)