fix(e2e): fix some async quirks

Author: Awk34

templates/app/e2e/account(auth)/login/login.spec(jasmine).js

@@ -56,12 +56,18 @@ describe('Login View', function() {
   describe('with local auth', function() {
 
     it('should login a user and redirecting to "/"', function() {
-      page.login(testUser);
-
-      var navbar = require('../../components/navbar/navbar.po');
-
-      expect(browser.getCurrentUrl()).toBe(config.baseUrl + '/');
-      expect(navbar.navbarAccountGreeting.getText()).toBe('Hello ' + testUser.name);
+      return page.login(testUser).then(() => {
+        var navbar = require('../../components/navbar/navbar.po');
+
+        return browser.wait(
+          () => element(by.css('.hero-unit')),
+          5000,
+          `Didn't find .hero-unit after 5s`
+        ).then(() => {
+          expect(browser.getCurrentUrl()).toBe(config.baseUrl + '/');
+          expect(navbar.navbarAccountGreeting.getText()).toBe('Hello ' + testUser.name);
+        });
+      });
     });
 
     it('should indicate login failures', function() {

templates/app/e2e/account(auth)/login/login.spec(mocha).js

@@ -56,12 +56,18 @@ describe('Login View', function() {
   describe('with local auth', function() {
 
     it('should login a user and redirecting to "/"', function() {
-      page.login(testUser);
-
-      var navbar = require('../../components/navbar/navbar.po');
-
-      <%= expect() %>browser.getCurrentUrl()<%= to() %>.eventually.equal(config.baseUrl + '/');
-      <%= expect() %>navbar.navbarAccountGreeting.getText()<%= to() %>.eventually.equal('Hello ' + testUser.name);
+      return page.login(testUser).then(() => {
+        var navbar = require('../../components/navbar/navbar.po');
+
+        return browser.wait(
+          () => element(by.css('.hero-unit')),
+          5000,
+          `Didn't find .hero-unit after 5s`
+        ).then(() => {
+          <%= expect() %>browser.getCurrentUrl()<%= to() %>.eventually.equal(config.baseUrl + '/');
+          <%= expect() %>navbar.navbarAccountGreeting.getText()<%= to() %>.eventually.equal('Hello ' + testUser.name);
+        });
+      });
     });
 
     describe('and invalid credentials', function() {