Commit 087f5bc
committed
fix(config): fix issue where
This is somewhat of a small issue discovered by @chair9design: #205 (comment).
`config.ip` is only defined in the production 'env' config file, so when running the server in any other environment (specifically development), no ip is passed to either `app.listen` or `console.log`(within server.js).
From what i can tell, passing a null hostname to app.listen (which calls [server.listen](http://nodejs.org/api/http.html#http_server_listen_port_hostname_backlog_callback) ) is not an issue. However, since we are directly using this config variable in server.js, it seems like we should default it to something.config.ip is undefined in non-production environments1 parent 2641e3e commit 087f5bc
1 file changed
+1
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
0 commit comments