refactor/add option to enable diskann#472
Open
richyreachy wants to merge 3 commits into
Open
Conversation
richyreachy
requested review from
Cuiyus,
egolearner and
feihongxu0824
as code owners
| if(NOT ENABLE_DISKANN) | ||
| set(DISKANN_SUPPORTED OFF) | ||
| add_definitions(-DDISKANN_SUPPORTED=0) | ||
| message(STATUS "DiskAnn support disabled by ENABLE_DISKANN=OFF") |
Collaborator
There was a problem hiding this comment.
这里还是不太对吧，默认行为应该是要判断当前编译环境是否有libaio的存在，如果存在，那么默认编译diskann；如果不存在，那么不编译diskann；
如果用户强制指定编译diskann，那么就需要检查当前环境是否存在libaio，如果不存在则报错
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add option to enable diskann