[SelectiveAuthenticator] TypeError when attempting to create SessionTokenAuthenticator

[morgan-dgk]

Component

SelectiveAuthenticator Component Factory

Description

Attempting to create a SelectiveAuthenticator which includes a SessionTokenAuthenticator currently fails with TypeError: ModelToComponentFactory.create_session_token_authenticator() missing 1 required positional argument: "'name' ","failure_type":"system_error"

This is because create_selective_authenticator does not pass kwargs to the ModelToComponentFactory._create_component_from_modelwhen creating authenticators for the SelectiveAuthenticator. kwargs contains the name argument passed down from create_declarative_streamwhich is required in create_session_token_authenticator

Proposed solution

Pass kwargs to _create_component_from_model when creating authenticators for SelectiveAuthenticator

✅ Yes, I want to contribute

[morgan-dgk]

This is also a problem when creating custom components with a nested SessionTokenAuthenticator. This is because name is not passed as a positional argument

[janad182]

I have the same issue.

Perhaps, the possible solution could be to add name to the _create_component_from_model call in this file: https://github.com/airbytehq/airbyte-python-cdk/blob/main/airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py (line 3226)

authenticators = {
    name: self._create_component_from_model(model=auth, config=config, name=name)
    for name, auth in model.authenticators.items()
}