add tests and renaming

Signed-off-by: Richard Chien <stdrc@outlook.com>

Author: stdrc

scripts/gen_schema.py

@@ -53,6 +53,7 @@
     "McpServer2": "SseMcpServer",
     "RequestPermissionOutcome1": "DeniedOutcome",
     "RequestPermissionOutcome2": "AllowedOutcome",
+    "SessionConfigOption1": "SessionConfigOptionSelect",
     "SessionUpdate1": "UserMessageChunk",
     "SessionUpdate2": "AgentMessageChunk",
     "SessionUpdate3": "AgentThoughtChunk",

src/acp/schema.py

@@ -2207,7 +2207,7 @@ class Content(BaseModel):
     ]
 
 
-class SessionConfigOption1(SessionConfigSelect):
+class SessionConfigOptionSelect(SessionConfigSelect):
     # The _meta property is reserved by ACP to allow clients and agents to attach additional
     # metadata to their interactions. Implementations MUST NOT make assumptions about values at
     # these keys.
@@ -2232,14 +2232,14 @@ class SessionConfigOption1(SessionConfigSelect):
     type: Literal["select"]
 
 
-class SessionConfigOption(RootModel[SessionConfigOption1]):
+class SessionConfigOption(RootModel[SessionConfigOptionSelect]):
     # **UNSTABLE**
     #
     # This capability is not part of the spec yet, and may be removed or changed at any point.
     #
     # A session configuration option selector and its current state.
     root: Annotated[
-        SessionConfigOption1,
+        SessionConfigOptionSelect,
         Field(
             description="**UNSTABLE**\n\nThis capability is not part of the spec yet, and may be removed or changed at any point.\n\nA session configuration option selector and its current state.",
             discriminator="type",
@@ -2781,6 +2781,7 @@ class AgentNotification(BaseModel):
 McpServer2 = SseMcpServer
 RequestPermissionOutcome1 = DeniedOutcome
 RequestPermissionOutcome2 = AllowedOutcome
+SessionConfigOption1 = SessionConfigOptionSelect
 SessionUpdate1 = UserMessageChunk
 SessionUpdate10 = SessionInfoUpdate
 SessionUpdate2 = AgentMessageChunk

tests/conftest.py

@@ -34,6 +34,7 @@
     AudioContentBlock,
     AvailableCommandsUpdate,
     ClientCapabilities,
+    ConfigOptionUpdate,
     CurrentModeUpdate,
     DeniedOutcome,
     EmbeddedResourceContentBlock,
@@ -173,6 +174,7 @@ async def session_update(
         | AgentPlanUpdate
         | AvailableCommandsUpdate
         | CurrentModeUpdate
+        | ConfigOptionUpdate
         | SessionInfoUpdate,
         **kwargs: Any,
     ) -> None:

tests/golden/session_update_config_option_update.json

@@ -0,0 +1,55 @@
+{
+  "sessionUpdate": "config_option_update",
+  "configOptions": [
+    {
+      "type": "select",
+      "id": "model",
+      "name": "Model",
+      "description": "Choose a model",
+      "currentValue": "gpt-4o-mini",
+      "options": [
+        {
+          "name": "GPT-4o Mini",
+          "value": "gpt-4o-mini"
+        },
+        {
+          "name": "GPT-4o",
+          "value": "gpt-4o",
+          "description": "Highest quality"
+        }
+      ]
+    },
+    {
+      "type": "select",
+      "id": "mode",
+      "name": "Mode",
+      "currentValue": "fast",
+      "options": [
+        {
+          "group": "speed",
+          "name": "Speed",
+          "options": [
+            {
+              "name": "Fast",
+              "value": "fast"
+            },
+            {
+              "name": "Balanced",
+              "value": "balanced"
+            }
+          ]
+        },
+        {
+          "group": "quality",
+          "name": "Quality",
+          "options": [
+            {
+              "name": "High",
+              "value": "high"
+            }
+          ]
+        }
+      ]
+    }
+  ]
+}

tests/golden/set_session_config_option_request.json

@@ -0,0 +1,5 @@
+{
+  "sessionId": "sess-123",
+  "configId": "model",
+  "value": "gpt-4o-mini"
+}

tests/golden/set_session_config_option_response.json

@@ -0,0 +1,20 @@
+{
+  "configOptions": [
+    {
+      "type": "select",
+      "id": "mode",
+      "name": "Mode",
+      "currentValue": "balanced",
+      "options": [
+        {
+          "name": "Fast",
+          "value": "fast"
+        },
+        {
+          "name": "Balanced",
+          "value": "balanced"
+        }
+      ]
+    }
+  ]
+}

tests/test_golden.py

@@ -35,6 +35,7 @@
     AllowedOutcome,
     AudioContentBlock,
     CancelNotification,
+    ConfigOptionUpdate,
     ContentToolCallContent,
     DeniedOutcome,
     EmbeddedResourceContentBlock,
@@ -50,6 +51,8 @@
     RequestPermissionRequest,
     RequestPermissionResponse,
     ResourceContentBlock,
+    SetSessionConfigOptionRequest,
+    SetSessionConfigOptionResponse,
     TerminalToolCallContent,
     TextContentBlock,
     ToolCallLocation,
@@ -84,6 +87,7 @@
     "request_permission_response_selected": RequestPermissionResponse,
     "session_update_agent_message_chunk": AgentMessageChunk,
     "session_update_agent_thought_chunk": AgentThoughtChunk,
+    "session_update_config_option_update": ConfigOptionUpdate,
     "session_update_plan": AgentPlanUpdate,
     "session_update_tool_call": ToolCallStart,
     "session_update_tool_call_edit": ToolCallStart,
@@ -92,6 +96,8 @@
     "session_update_tool_call_update_content": ToolCallProgress,
     "session_update_tool_call_update_more_fields": ToolCallProgress,
     "session_update_user_message_chunk": UserMessageChunk,
+    "set_session_config_option_request": SetSessionConfigOptionRequest,
+    "set_session_config_option_response": SetSessionConfigOptionResponse,
     "tool_content_content_text": ContentToolCallContent,
     "tool_content_diff": FileEditToolCallContent,
     "tool_content_diff_no_old": FileEditToolCallContent,