Add shellcheck and fix issues#70
Open
Tim Hockin (thockin) wants to merge 2 commits into
Open
Conversation
Tim Hockin (thockin)
force-pushed
the
add-shellcheck
branch
from
9f1a81b to
a53e448
Compare
Davanum Srinivas (dims)
approved these changes
May 23, 2026
Collaborator
Davanum Srinivas (dims)
left a comment
Davanum Srinivas (dims)
left a comment
There was a problem hiding this comment.
LGTM
One question though: do we want to standardize in #!/usr/bin/env bash in all scripts?
Collaborator
Author
Probably. I can add a commit here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not too many were found. Let's keep it that way.