Commit ef5cda0
refactor: Migrate to datamodel-code-generator for type generation
Replace custom 900-line type generator with battle-tested datamodel-code-generator library.
## Changes
### Type Generation
- Generate Pydantic models from JSON schemas using datamodel-code-generator
- All 101 schemas now generate proper Pydantic v2 models
- Models inherit from AdCPBaseModel to maintain `exclude_none=True` serialization
- Generated types use proper Pydantic types (AnyUrl, AwareDatetime, Field validators)
### Backward Compatibility
- Added 22 type aliases to preserve existing API surface
- Aliases: ActivateSignalSuccess/Error, CreateMediaBuySuccess/Error, etc.
- Deployment/Destination variants: PlatformDeployment, AgentDeployment, etc.
### Schema Sync Improvements
- Added ETag support for efficient schema updates
- Added --force flag to bypass ETags and force re-download
- Cache ETags in .etags.json for conditional downloads
- Better status reporting (not modified, updated, cached, forced)
### Test Updates
- Fixed test_discriminated_unions.py for new schemas
- Fixed test_format_id_validation.py for new error messages
- Updated Error object construction to use dict syntax
- Added URL type handling for AnyUrl comparisons
- All migration-related tests passing (219/229 total)
### Files
- New: src/adcp/types/generated_poc/ (101 generated type files)
- Modified: src/adcp/types/generated.py (consolidated exports)
- Modified: scripts/sync_schemas.py (ETag support)
- Modified: schemas/cache/ (synced with latest AdCP v1.0.0)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>1 parent d0123af commit ef5cda0
File tree
159 files changed
+17896
-2090
lines changed- schemas/cache
- 1.0.0
- scripts
- src/adcp/types
- generated_poc
- tests
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
159 files changed
+17896
-2090
lines changedLarge diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
| 122 | + | |
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
0 commit comments