fix: resolve mypy type errors for CI compliance

- Skip generating type aliases for PreviewCreativeRequest and PreviewCreativeResponse
  (they're implemented as full Pydantic classes in custom implementations section)
- Use Field(default=...) instead of Field(...) for Pydantic v2 compatibility
- Add explicit type annotations for list variables to satisfy mypy variance checks
- Add type ignore comments for adapter method calls and output_format str literals
- Fix triple-quote syntax error in generator script (use single quotes for multi-line strings)
- All 106 tests passing

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: bokelley

scripts/generate_models_simple.py

@@ -326,28 +326,28 @@ class PreviewCreativeRequest(BaseModel):
     """Request to generate a preview of a creative manifest. Supports single or batch mode."""
 
     # Single mode fields
-    format_id: FormatId | None = Field(None, description="Format identifier for rendering the preview (single mode)")
-    creative_manifest: CreativeManifest | None = Field(None, description="Complete creative manifest with all required assets (single mode)")
-    inputs: list[dict[str, Any]] | None = Field(None, description="Array of input sets for generating multiple preview variants")
-    template_id: str | None = Field(None, description="Specific template ID for custom format rendering")
+    format_id: FormatId | None = Field(default=None, description="Format identifier for rendering the preview (single mode)")
+    creative_manifest: CreativeManifest | None = Field(default=None, description="Complete creative manifest with all required assets (single mode)")
+    inputs: list[dict[str, Any]] | None = Field(default=None, description="Array of input sets for generating multiple preview variants")
+    template_id: str | None = Field(default=None, description="Specific template ID for custom format rendering")
 
     # Batch mode field
-    requests: list[dict[str, Any]] | None = Field(None, description="Array of preview requests for batch processing (1-50 items)")
+    requests: list[dict[str, Any]] | None = Field(default=None, description="Array of preview requests for batch processing (1-50 items)")
 
     # Output format (applies to both modes)
-    output_format: Literal["url", "html"] | None = Field("url", description="Output format: 'url' for iframe URLs, 'html' for direct embedding")
+    output_format: Literal["url", "html"] | None = Field(default="url", description="Output format: 'url' for iframe URLs, 'html' for direct embedding")
 
 
 class PreviewCreativeResponse(BaseModel):
     """Response containing preview links for one or more creatives. Format matches the request: single preview response for single requests, batch results for batch requests."""
 
     # Single mode fields
-    previews: list[dict[str, Any]] | None = Field(None, description="Array of preview variants (single mode)")
-    interactive_url: str | None = Field(None, description="Optional URL to interactive testing page (single mode)")
-    expires_at: str | None = Field(None, description="ISO 8601 timestamp when preview links expire (single mode)")
+    previews: list[dict[str, Any]] | None = Field(default=None, description="Array of preview variants (single mode)")
+    interactive_url: str | None = Field(default=None, description="Optional URL to interactive testing page (single mode)")
+    expires_at: str | None = Field(default=None, description="ISO 8601 timestamp when preview links expire (single mode)")
 
     # Batch mode field
-    results: list[dict[str, Any]] | None = Field(None, description="Array of preview results for batch processing")
+    results: list[dict[str, Any]] | None = Field(default=None, description="Array of preview results for batch processing")
 '''
     return code + custom_code
 
@@ -470,7 +470,12 @@ def main():
     )
 
     # Generate task models
+    # Skip preview types - they're implemented in custom implementations section
+    skip_types = {"preview-creative-request", "preview-creative-response"}
     for schema_file in task_schemas:
+        if schema_file.stem in skip_types:
+            print(f"  Skipping {schema_file.stem} (custom implementation)...")
+            continue
         print(f"  Generating task type: {schema_file.stem}...")
         try:
             model_code = generate_model_for_schema(schema_file)

src/adcp/client.py

@@ -257,7 +257,7 @@ async def preview_creative(
             )
         )
 
-        raw_result = await self.adapter.preview_creative(params)
+        raw_result = await self.adapter.preview_creative(params)  # type: ignore[attr-defined]
 
         self._emit_activity(
             Activity(

src/adcp/types/generated.py

@@ -456,11 +456,6 @@ class ListCreativesRequest(BaseModel):
     fields: list[Literal["creative_id", "name", "format", "status", "created_date", "updated_date", "tags", "assignments", "performance", "sub_assets"]] | None = Field(None, description="Specific fields to include in response (omit for all fields)")
 
 
-# Type alias for Preview Creative Request
-# Request to generate previews of one or more creative manifests. Accepts either a single creative request or an array of requests for batch processing.
-PreviewCreativeRequest = Any
-
-
 class ProvidePerformanceFeedbackRequest(BaseModel):
     """Request payload for provide_performance_feedback task"""
 
@@ -582,11 +577,6 @@ class ListCreativesResponse(BaseModel):
     status_summary: dict[str, Any] | None = Field(None, description="Breakdown of creatives by status")
 
 
-# Type alias for Preview Creative Response
-# Response containing preview links for one or more creatives. Format matches the request: single preview response for single requests, batch results for batch requests.
-PreviewCreativeResponse = Any
-
-
 class ProvidePerformanceFeedbackResponse(BaseModel):
     """Response payload for provide_performance_feedback task"""
 
@@ -641,25 +631,25 @@ class PreviewCreativeRequest(BaseModel):
     """Request to generate a preview of a creative manifest. Supports single or batch mode."""
 
     # Single mode fields
-    format_id: FormatId | None = Field(None, description="Format identifier for rendering the preview (single mode)")
-    creative_manifest: CreativeManifest | None = Field(None, description="Complete creative manifest with all required assets (single mode)")
-    inputs: list[dict[str, Any]] | None = Field(None, description="Array of input sets for generating multiple preview variants")
-    template_id: str | None = Field(None, description="Specific template ID for custom format rendering")
+    format_id: FormatId | None = Field(default=None, description="Format identifier for rendering the preview (single mode)")
+    creative_manifest: CreativeManifest | None = Field(default=None, description="Complete creative manifest with all required assets (single mode)")
+    inputs: list[dict[str, Any]] | None = Field(default=None, description="Array of input sets for generating multiple preview variants")
+    template_id: str | None = Field(default=None, description="Specific template ID for custom format rendering")
 
     # Batch mode field
-    requests: list[dict[str, Any]] | None = Field(None, description="Array of preview requests for batch processing (1-50 items)")
+    requests: list[dict[str, Any]] | None = Field(default=None, description="Array of preview requests for batch processing (1-50 items)")
 
     # Output format (applies to both modes)
-    output_format: Literal["url", "html"] | None = Field("url", description="Output format: 'url' for iframe URLs, 'html' for direct embedding")
+    output_format: Literal["url", "html"] | None = Field(default="url", description="Output format: 'url' for iframe URLs, 'html' for direct embedding")
 
 
 class PreviewCreativeResponse(BaseModel):
     """Response containing preview links for one or more creatives. Format matches the request: single preview response for single requests, batch results for batch requests."""
 
     # Single mode fields
-    previews: list[dict[str, Any]] | None = Field(None, description="Array of preview variants (single mode)")
-    interactive_url: str | None = Field(None, description="Optional URL to interactive testing page (single mode)")
-    expires_at: str | None = Field(None, description="ISO 8601 timestamp when preview links expire (single mode)")
+    previews: list[dict[str, Any]] | None = Field(default=None, description="Array of preview variants (single mode)")
+    interactive_url: str | None = Field(default=None, description="Optional URL to interactive testing page (single mode)")
+    expires_at: str | None = Field(default=None, description="ISO 8601 timestamp when preview links expire (single mode)")
 
     # Batch mode field
-    results: list[dict[str, Any]] | None = Field(None, description="Array of preview results for batch processing")
+    results: list[dict[str, Any]] | None = Field(default=None, description="Array of preview results for batch processing")

src/adcp/utils/preview_cache.py

@@ -126,9 +126,9 @@ async def get_preview_data_batch(
         ]
 
         # Separate cached vs uncached requests
-        uncached_indices = []
-        uncached_requests = []
-        results = [None] * len(requests)
+        uncached_indices: list[int] = []
+        uncached_requests: list[dict[str, Any]] = []
+        results: list[dict[str, Any] | None] = [None] * len(requests)
 
         for idx, (cache_key, (format_id, manifest)) in enumerate(zip(cache_keys, requests)):
             if cache_key in self._preview_cache:
@@ -160,7 +160,7 @@ async def get_preview_data_batch(
 
                 batch_request = PreviewCreativeRequest(
                     requests=chunk_requests,
-                    output_format=output_format,
+                    output_format=output_format,  # type: ignore[arg-type]
                 )
                 result = await self.creative_agent_client.preview_creative(batch_request)