Skip to content

Commit e30abba

Browse files
bokelleyclaude
andcommitted
fix: use conversational message for zero products
Changes "Found 0 products..." to "No products matched your requirements." for a more natural user experience. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 3639633 commit e30abba

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/adcp/types/base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ def decorator(func: MessageFormatter) -> MessageFormatter:
3737
@_register_response_message("GetProductsResponse")
3838
def _get_products_message(self: Any) -> str:
3939
products = getattr(self, "products", None)
40-
if products is None:
41-
return "No products found."
40+
if products is None or len(products) == 0:
41+
return "No products matched your requirements."
4242
count = len(products)
4343
return f"Found {count} {_pluralize(count, 'product')} matching your requirements."
4444

tests/test_response_str.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ def test_multiple_products(self):
5252
assert str(response) == "Found 3 products matching your requirements."
5353

5454
def test_zero_products(self):
55-
"""Zero products uses plural form."""
55+
"""Zero products uses conversational message."""
5656
response = GetProductsResponse.model_construct(products=[])
57-
assert str(response) == "Found 0 products matching your requirements."
57+
assert str(response) == "No products matched your requirements."
5858

5959

6060
class TestListCreativeFormatsResponseStr:

0 commit comments

Comments
 (0)