feat: add pytest markers, coverage config, security scanning, and integration tests

High-priority code hygiene improvements:

1. **Pytest markers**: Added unit/integration/slow markers
   - Integration tests excluded by default for fast local feedback
   - Run with: pytest -m integration to include them

2. **Coverage configuration**:
   - Set 80% minimum threshold (current: 86%)
   - Exclude generated code and test files
   - Branch coverage enabled
   - HTML reports to htmlcov/

3. **Bandit security scanning**:
   - Added to pre-commit hooks
   - Configured to skip tests and scripts
   - Allows assert statements (not using -O optimization)

4. **Integration tests converted to pytest**:
   - tests/integration/test_creative_agent.py now uses pytest
   - Tests creative.adcontextprotocol.org reference agent
   - Includes error handling test

These changes ensure:
- Code quality checks run automatically before commits
- Test coverage doesn't drop below acceptable threshold
- Security vulnerabilities are caught early
- Integration tests are properly organized

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: bokelley

.pre-commit-config.yaml

@@ -30,6 +30,15 @@ repos:
         pass_filenames: false
         args: [src/adcp]
 
+  # Security scanning with bandit
+  - repo: https://github.com/PyCQA/bandit
+    rev: 1.7.10
+    hooks:
+      - id: bandit
+        args: ["-c", "pyproject.toml"]
+        additional_dependencies: ["bandit[toml]"]
+        exclude: ^(tests/|scripts/)
+
   # Basic file checks
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v5.0.0

pyproject.toml

@@ -101,6 +101,47 @@ ignore_errors = true
 [tool.pytest.ini_options]
 testpaths = ["tests"]
 asyncio_mode = "auto"
+markers = [
+    "unit: Unit tests that don't require external services",
+    "integration: Integration tests that hit real endpoints (may be slow/flaky)",
+    "slow: Tests that take significant time to run",
+]
+# By default, skip integration tests for fast local development
+addopts = "-m 'not integration'"
+
+[tool.coverage.run]
+source = ["src/adcp"]
+omit = [
+    "*/tests/*",
+    "*/test_*.py",
+    "*/_generated.py",
+    "*/generated_poc/*",
+]
+branch = true
+
+[tool.coverage.report]
+precision = 2
+show_missing = true
+skip_covered = false
+exclude_lines = [
+    "pragma: no cover",
+    "def __repr__",
+    "raise AssertionError",
+    "raise NotImplementedError",
+    "if __name__ == .__main__.:",
+    "if TYPE_CHECKING:",
+    "class .*\\bProtocol\\):",
+    "@(abc\\.)?abstractmethod",
+]
+# Maintain current 86% coverage, fail if it drops below 80%
+fail_under = 80
+
+[tool.coverage.html]
+directory = "htmlcov"
+
+[tool.bandit]
+exclude_dirs = ["tests", "scripts"]
+skips = ["B101"]  # Allow assert in code (we're not using -O optimization)
 
 [dependency-groups]
 dev = [

tests/integration/test_creative_agent.py

@@ -1,55 +1,44 @@
 """Integration tests for the creative agent at creative.adcontextprotocol.org."""
 
-import asyncio
-import sys
-from pathlib import Path
-
-# Add src to path for imports
-sys.path.insert(0, str(Path(__file__).parent.parent.parent / "src"))
+import pytest
 
 from adcp import ADCPClient
-from adcp.types import AgentConfig, Protocol
-
+from adcp.types import AgentConfig, ListCreativeFormatsRequest, Protocol
 
-async def test_creative_agent():
-    """Test the reference creative agent."""
-    print("\n" + "=" * 60)
-    print("Testing Creative Agent (MCP)")
-    print("=" * 60)
 
+@pytest.mark.integration
+@pytest.mark.asyncio
+async def test_creative_agent_list_formats():
+    """Test the reference creative agent can list formats."""
     config = AgentConfig(
         id="creative_agent",
         agent_uri="https://creative.adcontextprotocol.org",
         protocol=Protocol.MCP,
     )
 
-    client = ADCPClient(config)
-
-    # Test 1: List creative formats
-    print("\n📋 Test 1: Listing creative formats...")
-    try:
-        result = await client.list_creative_formats()
-        if result.success:
-            print("✅ Success!")
-            print(f"Status: {result.status}")
-            print(f"Data: {result.data}")
-        else:
-            print(f"❌ Failed: {result.error}")
-    except Exception as e:
-        print(f"❌ Exception: {e}")
-
-    # Clean up
-    if hasattr(client.adapter, "close"):
-        await client.adapter.close()
+    async with ADCPClient(config) as client:
+        request = ListCreativeFormatsRequest()
+        result = await client.list_creative_formats(request)
 
+        assert result.success, f"Failed to list formats: {result.error}"
+        assert result.data is not None, "Expected data in response"
+        assert hasattr(result.data, "formats"), "Expected formats in data"
+        assert len(result.data.formats) > 0, "Expected at least one format"
 
-async def main():
-    """Run all tests."""
-    await test_creative_agent()
-    print("\n" + "=" * 60)
-    print("Integration tests completed")
-    print("=" * 60 + "\n")
 
+@pytest.mark.integration
+@pytest.mark.asyncio
+async def test_creative_agent_connection_error_handling():
+    """Test that connection errors are handled gracefully."""
+    config = AgentConfig(
+        id="invalid_agent",
+        agent_uri="https://invalid.example.com/nonexistent",
+        protocol=Protocol.MCP,
+        timeout=2.0,  # Short timeout for faster test
+    )
 
-if __name__ == "__main__":
-    asyncio.run(main())
+    # Should raise an exception for invalid endpoint
+    with pytest.raises(Exception):
+        async with ADCPClient(config) as client:
+            request = ListCreativeFormatsRequest()
+            await client.list_creative_formats(request)