refactor: remove direct generated_poc imports

Replace all direct imports from adcp.types.generated_poc with imports from
adcp.types._generated. This enforces the public API boundary and prevents
downstream users from depending on internal implementation details.

Changes:
- Update consolidate_exports.py to handle Package name collision by exporting
  both types with qualified names (_PackageFromPackage, _PackageFromCreateMediaBuyResponse)
- Migrate client.py to import TaskStatus from _generated
- Migrate aliases.py to import all types from _generated
- Migrate stable.py to import Package from _generated using qualified name
- Regenerate _generated.py with collision-resolved exports

This ensures that:
1. generated_poc directory remains internal (not part of public API)
2. All type consolidation happens in _generated.py
3. Only stable.py and aliases.py provide public type exports
4. Users import from adcp or adcp.types.stable, not internal modules

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: bokelley

scripts/consolidate_exports.py

@@ -58,6 +58,11 @@ def generate_consolidated_exports() -> str:
     all_exports = set()
     collisions = []
 
+    # Special handling for known collision: Package type
+    # We need BOTH Package types available, so import them with qualified names
+    special_imports = []
+    package_modules_seen = set()
+
     for module_path in modules:
         module_name = module_path.stem
         exports = extract_exports_from_module(module_path)
@@ -68,9 +73,15 @@ def generate_consolidated_exports() -> str:
         # Filter out names that collide with already-exported names
         unique_exports = set()
         for export_name in exports:
+            # Special case: Package collision - track all modules that define it
+            if export_name == "Package" and module_name in ("package", "create_media_buy_response"):
+                package_modules_seen.add(module_name)
+                export_to_module[export_name] = module_name  # Track that we've seen it
+                continue  # Don't add to unique_exports, we'll handle specially
+
             if export_name in export_to_module:
-                # Collision detected - skip this duplicate
                 first_module = export_to_module[export_name]
+                # Collision detected - skip this duplicate
                 collisions.append(
                     f"  {export_name}: defined in both {first_module} and {module_name} (using {first_module})"
                 )
@@ -91,6 +102,16 @@ def generate_consolidated_exports() -> str:
 
         all_exports.update(unique_exports)
 
+    # Generate special imports for Package collision
+    if package_modules_seen:
+        collisions.append(f"  Package: defined in {sorted(package_modules_seen)} (both exported with qualified names)")
+        for module_name in sorted(package_modules_seen):
+            qualified_name = f"_PackageFrom{module_name.replace('_', ' ').title().replace(' ', '')}"
+            special_imports.append(
+                f"from adcp.types.generated_poc.{module_name} import Package as {qualified_name}"
+            )
+            all_exports.add(qualified_name)
+
     if collisions:
         print("\n⚠️  Name collisions detected (duplicates skipped):")
         for collision in sorted(collisions):
@@ -121,6 +142,11 @@ def generate_consolidated_exports() -> str:
 
     lines.extend(import_lines)
 
+    # Add special imports for name collisions
+    if special_imports:
+        lines.extend(["", "# Special imports for name collisions (Package type)"])
+        lines.extend(special_imports)
+
     # Add backward compatibility aliases (only if source exists)
     aliases = {}
     if "AdvertisingChannels" in all_exports:

src/adcp/client.py

@@ -38,6 +38,7 @@
     ProvidePerformanceFeedbackResponse,
     SyncCreativesRequest,
     SyncCreativesResponse,
+    TaskStatus as GeneratedTaskStatus,
     WebhookPayload,
 )
 from adcp.types.core import (
@@ -48,7 +49,6 @@
     TaskResult,
     TaskStatus,
 )
-from adcp.types.generated_poc.task_status import TaskStatus as GeneratedTaskStatus
 from adcp.utils.operation_id import create_operation_id
 
 logger = logging.getLogger(__name__)

src/adcp/types/_generated.py

@@ -10,7 +10,7 @@
 DO NOT EDIT MANUALLY.
 
 Generated from: https://github.com/adcontextprotocol/adcp/tree/main/schemas
-Generation date: 2025-11-18 12:52:17 UTC
+Generation date: 2025-11-19 01:13:16 UTC
 """
 # ruff: noqa: E501, I001
 from __future__ import annotations
@@ -33,7 +33,7 @@
 from adcp.types.generated_poc.cpp_option import CppPricingOption, Parameters
 from adcp.types.generated_poc.cpv_option import CpvPricingOption, ViewThreshold, ViewThreshold1
 from adcp.types.generated_poc.create_media_buy_request import CreateMediaBuyRequest, ReportingFrequency, ReportingWebhook, RequestedMetric
-from adcp.types.generated_poc.create_media_buy_response import CreateMediaBuyResponse, CreateMediaBuyResponse1, CreateMediaBuyResponse2, Package
+from adcp.types.generated_poc.create_media_buy_response import CreateMediaBuyResponse, CreateMediaBuyResponse1, CreateMediaBuyResponse2
 from adcp.types.generated_poc.creative_asset import CreativeAsset, Input
 from adcp.types.generated_poc.creative_assignment import CreativeAssignment
 from adcp.types.generated_poc.creative_manifest import CreativeManifest
@@ -113,6 +113,10 @@
 from adcp.types.generated_poc.webhook_asset import Method, Method1, ResponseType, Security, WebhookAsset
 from adcp.types.generated_poc.webhook_payload import WebhookPayload
 
+# Special imports for name collisions (Package type)
+from adcp.types.generated_poc.create_media_buy_response import Package as _PackageFromCreateMediaBuyResponse
+from adcp.types.generated_poc.package import Package as _PackageFromPackage
+
 # Backward compatibility aliases for renamed types
 Channels = AdvertisingChannels
 
@@ -146,9 +150,9 @@
     "ListCreativesResponse", "Logo", "MarkdownAsset", "MarkdownFlavor", "Measurement",
     "MeasurementPeriod", "MediaBuy", "MediaBuyDelivery", "MediaBuyStatus", "Metadata", "Method",
     "Method1", "MetricType", "ModuleType", "NotificationType", "Offering", "OutputFormat",
-    "Pacing", "Package", "PackageRequest", "PackageStatus", "Packages", "Packages1", "Packages2",
-    "Packages3", "Pagination", "Parameters", "Performance", "PerformanceFeedback", "Placement",
-    "Preview", "Preview1", "Preview2", "PreviewCreativeRequest", "PreviewCreativeRequest1",
+    "Pacing", "PackageRequest", "PackageStatus", "Packages", "Packages1", "Packages2", "Packages3",
+    "Pagination", "Parameters", "Performance", "PerformanceFeedback", "Placement", "Preview",
+    "Preview1", "Preview2", "PreviewCreativeRequest", "PreviewCreativeRequest1",
     "PreviewCreativeRequest2", "PreviewCreativeResponse", "PreviewCreativeResponse1",
     "PreviewCreativeResponse2", "PreviewRender", "PreviewRender1", "PreviewRender2",
     "PreviewRender3", "PriceGuidance", "Pricing", "PricingModel", "PrimaryCountry", "Product",
@@ -171,5 +175,6 @@
     "UpdateMediaBuyResponse", "UpdateMediaBuyResponse1", "UpdateMediaBuyResponse2", "UrlAsset",
     "UrlType", "ValidationMode", "VastAsset1", "VastAsset2", "VastVersion",
     "VcpmAuctionPricingOption", "VcpmFixedRatePricingOption", "VenueBreakdownItem", "VideoAsset",
-    "ViewThreshold", "ViewThreshold1", "WebhookAsset", "WebhookPayload"
+    "ViewThreshold", "ViewThreshold1", "WebhookAsset", "WebhookPayload",
+    "_PackageFromCreateMediaBuyResponse", "_PackageFromPackage"
 ]

src/adcp/types/aliases.py

@@ -33,6 +33,9 @@
 
 # Import all generated types that need semantic aliases
 from adcp.types._generated import (
+    # Package types (from name collision resolution)
+    _PackageFromCreateMediaBuyResponse as CreatedPackageInternal,
+    _PackageFromPackage as FullPackageInternal,
     # Activation responses
     ActivateSignalResponse1,
     ActivateSignalResponse2,
@@ -67,6 +70,12 @@
     # Performance feedback responses
     ProvidePerformanceFeedbackResponse1,
     ProvidePerformanceFeedbackResponse2,
+    # Publisher properties types
+    PropertyId,
+    PropertyTag,
+    PublisherProperties as PublisherPropertiesInternal,
+    PublisherProperties4 as PublisherPropertiesByIdInternal,
+    PublisherProperties5 as PublisherPropertiesByTagInternal,
     # SubAssets
     SubAsset1,
     SubAsset2,
@@ -84,27 +93,6 @@
     VastAsset2,
 )
 
-# Import Package types directly from their modules to avoid collision issues
-from adcp.types.generated_poc.create_media_buy_response import (
-    Package as CreatedPackageInternal,
-)
-from adcp.types.generated_poc.package import Package as FullPackageInternal
-
-# Import PublisherProperties types and related types from product module
-from adcp.types.generated_poc.product import (
-    PropertyId,
-    PropertyTag,
-)
-from adcp.types.generated_poc.product import (
-    PublisherProperties as PublisherPropertiesInternal,
-)
-from adcp.types.generated_poc.product import (
-    PublisherProperties4 as PublisherPropertiesByIdInternal,
-)
-from adcp.types.generated_poc.product import (
-    PublisherProperties5 as PublisherPropertiesByTagInternal,
-)
-
 # ============================================================================
 # RESPONSE TYPE ALIASES - Success/Error Discriminated Unions
 # ============================================================================

src/adcp/types/stable.py

@@ -93,8 +93,8 @@
 )
 
 # Import all generated types from internal consolidated module
-# Import Package directly from its module to avoid collision with Response Package
-from adcp.types.generated_poc.package import Package
+# Import Package from _generated (uses qualified name to avoid collision)
+from adcp.types._generated import _PackageFromPackage as Package
 
 # Note: BrandManifest is currently split into BrandManifest1/2 due to upstream schema
 # using anyOf incorrectly. This will be fixed upstream to create a single BrandManifest type.