Update Patch constraint and add a test for the constraint

Signed-off-by: ziad hany <ziadhany2016@gmail.com>

Author: ziadhany

vulnerabilities/migrations/0104_packagecommitpatch_patch_and_more.py

@@ -1,4 +1,4 @@
-# Generated by Django 4.2.25 on 2025-12-11 12:23
+# Generated by Django 4.2.25 on 2025-12-11 21:28
 
 from django.db import migrations, models
 
@@ -102,9 +102,12 @@ class Migration(migrations.Migration):
             constraint=models.CheckConstraint(
                 check=models.Q(
                     models.Q(
-                        ("patch_url__isnull", False), ("patch_text__isnull", False), _connector="OR"
+                        ("patch_url__isnull", False), models.Q(("patch_url", ""), _negated=True)
                     ),
-                    models.Q(("patch_url", ""), ("patch_text", ""), _negated=True),
+                    models.Q(
+                        ("patch_text__isnull", False), models.Q(("patch_text", ""), _negated=True)
+                    ),
+                    _connector="OR",
                 ),
                 name="patch_url_or_patch_text",
             ),

vulnerabilities/models.py

@@ -2782,8 +2782,10 @@ class Meta:
         unique_together = ["patch_checksum", "patch_url"]
         constraints = [
             models.CheckConstraint(
-                check=(Q(patch_url__isnull=False) | Q(patch_text__isnull=False))
-                & ~(Q(patch_url="") & Q(patch_text="")),
+                check=(
+                    Q(patch_url__isnull=False) & ~Q(patch_url="")
+                    | Q(patch_text__isnull=False) & ~Q(patch_text="")
+                ),
                 name="patch_url_or_patch_text",
             )
         ]

vulnerabilities/tests/test_models.py

@@ -10,9 +10,11 @@
 import urllib.parse
 from datetime import datetime
 from unittest import TestCase
+from unittest.mock import patch
 
 import pytest
 from django.core.exceptions import ValidationError
+from django.db.utils import IntegrityError
 from django.test import TestCase as DjangoTestCase
 from packageurl import PackageURL
 from univers import versions
@@ -25,6 +27,7 @@
 from vulnerabilities.importer import Reference
 from vulnerabilities.models import Alias
 from vulnerabilities.models import Package
+from vulnerabilities.models import Patch
 from vulnerabilities.models import Vulnerability
 from vulnerabilities.utils import compute_content_id
 
@@ -647,9 +650,6 @@ def test_advisory_insert_no_duplicate_content_id(self):
             )
 
 
-from unittest.mock import patch
-
-
 class TestPipelineRunModel(DjangoTestCase):
     def setUp(self):
         self.schedule1 = models.PipelineSchedule.objects.create(pipeline_id="test_pipeline")
@@ -694,3 +694,29 @@ def test_pipelineschedule_latest_run_date(self):
 
     def test_pipelineschedule_all_runs(self):
         self.assertEqual(self.schedule1.all_runs.count(), 2)
+
+
+class PatchConstraintTests(TestCase):
+    @pytest.mark.django_db
+    def test_constraint_none(self):
+        with self.assertRaises(IntegrityError) as raised:
+            Patch.objects.create(patch_url=None, patch_text=None)
+        self.assertIn("patch_url_or_patch_text", str(raised.exception))
+
+    @pytest.mark.django_db
+    def test_constraint_empty(self):
+        with self.assertRaises(IntegrityError) as raised:
+            Patch.objects.create(patch_url="", patch_text="")
+        self.assertIn("patch_url_or_patch_text", str(raised.exception))
+
+    @pytest.mark.django_db
+    def test_constraint_empty_none(self):
+        with self.assertRaises(IntegrityError) as raised:
+            Patch.objects.create(patch_url="", patch_text=None)
+        self.assertIn("patch_url_or_patch_text", str(raised.exception))
+
+    @pytest.mark.django_db
+    def test_constraint_none_empty(self):
+        with self.assertRaises(IntegrityError) as raised:
+            Patch.objects.create(patch_url=None, patch_text="")
+        self.assertIn("patch_url_or_patch_text", str(raised.exception))