[ECO-5386] Removed jackson-msgpack dependencies

1. Implemented manual msgpack serialization
2. Updated tests

Author: sacOO7

gradle/libs.versions.toml

@@ -25,8 +25,6 @@ mockk = "1.14.2"
 turbine = "1.2.0"
 ktor = "3.1.3"
 jetbrains-annoations = "26.0.2"
-jackson-msgpack = "0.8.11" # Compatible with msgpack-core 0.8.11
-jackson-param = "2.19.1" # Compatible with jackson-msgpack
 
 [libraries]
 gson = { group = "com.google.code.gson", name = "gson", version.ref = "gson" }
@@ -56,8 +54,6 @@ turbine = { group = "app.cash.turbine", name = "turbine", version.ref = "turbine
 ktor-client-core = { module = "io.ktor:ktor-client-core", version.ref = "ktor" }
 ktor-client-cio = { module = "io.ktor:ktor-client-cio", version.ref = "ktor" }
 jetbrains = { group = "org.jetbrains", name = "annotations", version.ref = "jetbrains-annoations" }
-jackson-msgpack = { group = "org.msgpack", name = "jackson-dataformat-msgpack", version.ref = "jackson-msgpack" }
-jackson-parameter-names = { group = "com.fasterxml.jackson.module", name = "jackson-module-parameter-names", version.ref = "jackson-param" }
 
 [bundles]
 common = ["msgpack", "vcdiff-core"]

lib/src/main/java/io/ably/lib/objects/LiveObjectsHelper.java

@@ -27,7 +27,7 @@ public static LiveObjectsPlugin tryInitializeLiveObjectsPlugin(AblyRealtime ably
     public static LiveObjectSerializer getLiveObjectSerializer() {
         if (liveObjectSerializer == null) {
             try {
-                Class<?> serializerClass = Class.forName("io.ably.lib.objects.DefaultLiveObjectSerializer");
+                Class<?> serializerClass = Class.forName("io.ably.lib.objects.serialization.DefaultLiveObjectSerializer");
                 liveObjectSerializer = (LiveObjectSerializer) serializerClass.getDeclaredConstructor().newInstance();
             } catch (ClassNotFoundException | InstantiationException | IllegalAccessException | NoSuchMethodException |
                      InvocationTargetException e) {

lib/src/main/java/io/ably/lib/types/ProtocolSerializer.java

@@ -14,7 +14,7 @@ public class ProtocolSerializer {
     /****************************************
      *            Msgpack decode
      ****************************************/
-    
+
     public static ProtocolMessage readMsgpack(byte[] packed) throws AblyException {
         try {
             MessageUnpacker unpacker = Serialisation.msgpackUnpackerConfig.newUnpacker(packed);
@@ -27,30 +27,31 @@ public static ProtocolMessage readMsgpack(byte[] packed) throws AblyException {
     /****************************************
      *            Msgpack encode
      ****************************************/
-    
-    public static byte[] writeMsgpack(ProtocolMessage message) {
+
+    public static byte[] writeMsgpack(ProtocolMessage message) throws AblyException {
         ByteArrayOutputStream out = new ByteArrayOutputStream();
         MessagePacker packer = Serialisation.msgpackPackerConfig.newPacker(out);
         try {
             message.writeMsgpack(packer);
-    
             packer.flush();
             return out.toByteArray();
-        } catch(IOException e) { return null; }
+        } catch (IOException ioe) {
+            throw AblyException.fromThrowable(ioe);
+        }
     }
 
     /****************************************
      *              JSON decode
      ****************************************/
-    
+
     public static ProtocolMessage fromJSON(String packed) throws AblyException {
         return Serialisation.gson.fromJson(packed, ProtocolMessage.class);
     }
 
     /****************************************
      *              JSON encode
      ****************************************/
-    
+
     public static byte[] writeJSON(ProtocolMessage message) throws AblyException {
         return Serialisation.gson.toJson(message).getBytes(Charset.forName("UTF-8"));
     }

live-objects/build.gradle.kts

@@ -13,9 +13,6 @@ dependencies {
     implementation(project(":java"))
     implementation(libs.bundles.common)
     implementation(libs.coroutine.core)
-    implementation(libs.jackson.msgpack)
-    implementation(libs.jackson.parameter.names) // Add this
-
 
     testImplementation(kotlin("test"))
     testImplementation(libs.bundles.kotlin.tests)
@@ -47,12 +44,4 @@ tasks.register<Test>("runLiveObjectIntegrationTests") {
 
 kotlin {
     explicitApi()
-
-    /**
-     * Enables Jackson to map JSON property names to constructor parameters without use of @JsonProperty.
-     * Adds metadata params to bytecode class. Approach is completely binary-compatible with consumers of the library.
-     */
-    compilerOptions {
-        javaParameters = true
-    }
 }

live-objects/src/main/kotlin/io/ably/lib/objects/Helpers.kt

@@ -39,18 +39,18 @@ internal enum class ProtocolMessageFormat(private val value: String) {
   override fun toString(): String = value
 }
 
-internal class Binary(val data: ByteArray?) {
+internal class Binary(val data: ByteArray) {
   override fun equals(other: Any?): Boolean {
     if (this === other) return true
     if (other !is Binary) return false
-    return data?.contentEquals(other.data) == true
+    return data.contentEquals(other.data)
   }
 
   override fun hashCode(): Int {
-    return data?.contentHashCode() ?: 0
+    return data.contentHashCode()
   }
 }
 
 internal fun Binary.size(): Int {
-  return data?.size ?: 0
+  return data.size
 }

live-objects/src/main/kotlin/io/ably/lib/objects/ObjectMessage.kt

@@ -3,11 +3,11 @@ package io.ably.lib.objects
 import com.google.gson.JsonArray
 import com.google.gson.JsonObject
 
-import com.fasterxml.jackson.annotation.JsonProperty
-import com.fasterxml.jackson.databind.annotation.JsonDeserialize
-import com.fasterxml.jackson.databind.annotation.JsonSerialize
 import com.google.gson.annotations.JsonAdapter
 import com.google.gson.annotations.SerializedName
+import io.ably.lib.objects.serialization.InitialValueJsonSerializer
+import io.ably.lib.objects.serialization.ObjectDataJsonSerializer
+import io.ably.lib.objects.serialization.gson
 
 /**
  * An enum class representing the different actions that can be performed on an object.
@@ -35,8 +35,6 @@ internal enum class MapSemantics(val code: Int) {
  * Spec: OD1
  */
 @JsonAdapter(ObjectDataJsonSerializer::class)
-@JsonSerialize(using = ObjectDataMsgpackSerializer::class)
-@JsonDeserialize(using = ObjectDataMsgpackDeserializer::class)
 internal data class ObjectData(
   /**
    * A reference to another object, used to support composable object structures.
@@ -221,8 +219,6 @@ internal data class ObjectOperation(
    * Spec: OOP3h
    */
   @JsonAdapter(InitialValueJsonSerializer::class)
-  @JsonSerialize(using = InitialValueMsgpackSerializer::class)
-  @JsonDeserialize(using = InitialValueMsgpackDeserializer::class)
   val initialValue: Binary? = null,
 
   /** The initial value encoding defines how the initialValue should be interpreted.
@@ -319,7 +315,7 @@ internal data class ObjectMessage(
    * or validation of the @extras@ field itself, but should treat it opaquely, encoding it and passing it to realtime unaltered
    * Spec: OM2d
    */
-  val extras: Any? = null,
+  val extras: JsonObject? = null,
 
   /**
    * Describes an operation to be applied to an object.
@@ -336,7 +332,6 @@ internal data class ObjectMessage(
    * Spec: OM2g
    */
   @SerializedName("object")
-  @JsonProperty("object")
   val objectState: ObjectState? = null,
 
   /**