Code Modernization: Fix instances of using null as an array offset.

Addresses a new [https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_using_values_null_as_an_array_offset_and_when_calling_array_key_exists deprecation in PHP 8.5] in several block-related registry classes.

Follow-up to [60809].

Props mukesh27, swissspidy.
Fixes #63957.

git-svn-id: https://develop.svn.wordpress.org/trunk@60904 602fd350-edb4-49c9-b593-d223f7449a82

Author: swissspidy

src/wp-includes/class-wp-block-bindings-registry.php

@@ -249,11 +249,11 @@ public function get_registered( string $source_name ) {
 	 *
 	 * @since 6.5.0
 	 *
-	 * @param string $source_name The name of the source.
+	 * @param string|null $source_name The name of the source.
 	 * @return bool `true` if the block bindings source is registered, `false` otherwise.
 	 */
 	public function is_registered( $source_name ) {
-		return isset( $this->sources[ $source_name ] );
+		return isset( $source_name, $this->sources[ $source_name ] );
 	}
 
 	/**

src/wp-includes/class-wp-block-pattern-categories-registry.php

@@ -138,11 +138,11 @@ public function get_all_registered( $outside_init_only = false ) {
 	 *
 	 * @since 5.5.0
 	 *
-	 * @param string $category_name Pattern category name including namespace.
+	 * @param string|null $category_name Pattern category name including namespace.
 	 * @return bool True if the pattern category is registered, false otherwise.
 	 */
 	public function is_registered( $category_name ) {
-		return isset( $this->registered_categories[ $category_name ] );
+		return isset( $category_name, $this->registered_categories[ $category_name ] );
 	}
 
 	/**

src/wp-includes/class-wp-block-patterns-registry.php

@@ -238,11 +238,11 @@ public function get_all_registered( $outside_init_only = false ) {
 	 *
 	 * @since 5.5.0
 	 *
-	 * @param string $pattern_name Block pattern name including namespace.
+	 * @param string|null $pattern_name Block pattern name including namespace.
 	 * @return bool True if the pattern is registered, false otherwise.
 	 */
 	public function is_registered( $pattern_name ) {
-		return isset( $this->registered_patterns[ $pattern_name ] );
+		return isset( $pattern_name, $this->registered_patterns[ $pattern_name ] );
 	}
 
 	public function __wakeup() {

src/wp-includes/class-wp-block-styles-registry.php

@@ -181,12 +181,12 @@ public function get_registered_styles_for_block( $block_name ) {
 	 *
 	 * @since 5.3.0
 	 *
-	 * @param string $block_name       Block type name including namespace.
-	 * @param string $block_style_name Block style name.
+	 * @param string|null $block_name       Block type name including namespace.
+	 * @param string|null $block_style_name Block style name.
 	 * @return bool True if the block style is registered, false otherwise.
 	 */
 	public function is_registered( $block_name, $block_style_name ) {
-		return isset( $this->registered_block_styles[ $block_name ][ $block_style_name ] );
+		return isset( $block_name, $block_style_name, $this->registered_block_styles[ $block_name ][ $block_style_name ] );
 	}
 
 	/**

src/wp-includes/class-wp-block-templates-registry.php

@@ -204,11 +204,11 @@ public function get_by_query( $query = array() ) {
 	 *
 	 * @since 6.7.0
 	 *
-	 * @param string $template_name Template name.
+	 * @param string|null $template_name Template name.
 	 * @return bool True if the template is registered, false otherwise.
 	 */
 	public function is_registered( $template_name ) {
-		return isset( $this->registered_templates[ $template_name ] );
+		return isset( $template_name, $this->registered_templates[ $template_name ] );
 	}
 
 	/**

tests/phpunit/tests/block-bindings/wpBlockBindingsRegistry.php

@@ -344,4 +344,16 @@ public function test_is_registered_for_known_source() {
 		$result = $this->registry->is_registered( self::$test_source_name );
 		$this->assertTrue( $result );
 	}
+
+	/**
+	 * Should return false when checking registration with a null source name.
+	 *
+	 * @ticket 63957
+	 *
+	 * @covers WP_Block_Bindings_Registry::is_registered
+	 */
+	public function test_is_registered_with_null_source_name() {
+		$result = $this->registry->is_registered( null );
+		$this->assertFalse( $result );
+	}
 }

tests/phpunit/tests/block-pattern/wpBlockPatternCategoriesRegistry.php

@@ -0,0 +1,22 @@
+<?php
+/**
+ * Unit tests for WP_Block_Pattern_Categories_Registry::is_registered().
+ *
+ * @package WordPress
+ * @subpackage Blocks
+ * @since 6.9.0
+ *
+ * @group block-patterns
+ * @covers WP_Block_Pattern_Categories_Registry::is_registered
+ */
+
+class Tests_Block_Pattern_WPBlockPatternCategoriesRegistry extends WP_UnitTestCase {
+
+	/**
+	 * @ticket 63957
+	 */
+	public function test_is_registered_with_null_category_name() {
+		$registry = WP_Block_Pattern_Categories_Registry::get_instance();
+		$this->assertFalse( $registry->is_registered( null ) );
+	}
+}

tests/phpunit/tests/block-templates/WpBlockTemplatesRegistry.php

@@ -247,6 +247,15 @@ public function test_is_registered() {
 		self::$registry->unregister( $template_name );
 	}
 
+	/**
+	 * @ticket 63957
+	 *
+	 * @covers ::is_registered
+	 */
+	public function test_is_registered_with_null_template_name() {
+		$this->assertFalse( self::$registry->is_registered( null ) );
+	}
+
 	/**
 	 * Tests that unregister() correctly unregisters a registered template.
 	 *

tests/phpunit/tests/blocks/wpBlockPatternsRegistry.php

@@ -695,4 +695,11 @@ private function set_registered_patterns_variable_value( $value ) {
 			$property->setAccessible( false );
 		}
 	}
+
+	/**
+	 * @ticket 63957
+	 */
+	public function test_is_registered_with_null_pattern_name() {
+		$this->assertFalse( $this->registry->is_registered( null ) );
+	}
 }

tests/phpunit/tests/blocks/wpBlockStylesRegistry.php

@@ -66,4 +66,36 @@ public function test_register_block_style_with_array_of_block_names() {
 		$this->assertTrue( $this->registry->is_registered( 'core/paragraph', 'plain' ) );
 		$this->assertTrue( $this->registry->is_registered( 'core/group', 'plain' ) );
 	}
+
+	/**
+	 * @ticket 63957
+	 */
+	public function test_is_registered_returns_false_for_null_block_name() {
+		$style_name = 'fancy-style';
+		$this->assertFalse(
+			$this->registry->is_registered( null, $style_name ),
+			'Empty block name should return false.'
+		);
+	}
+
+	/**
+	 * @ticket 63957
+	 */
+	public function test_is_registered_returns_false_for_null_style_name() {
+		$block_name = 'core/paragraph';
+		$this->assertFalse(
+			$this->registry->is_registered( $block_name, null ),
+			'Empty style name should return false.'
+		);
+	}
+
+	/**
+	 * @ticket 63957
+	 */
+	public function test_is_registered_returns_false_for_both_null_params() {
+		$this->assertFalse(
+			$this->registry->is_registered( null, null ),
+			'Both empty block and style name should return false.'
+		);
+	}
 }