Privacy: A11y: Show time of privacy request status change.

Add the date and time of privacy request status changes in the privacy requests table. Previously, `human_time_diff()` was used in the first 24 hours, and only the date after 24 hours. Change the output to display both date and time after 24 hours, using the format used for comments.

Props birgire, desrosj, afercia, xkon, tz-media, garrett-eclipse, sirlouen, sukhendu2002, sajjad67, fakhriaz, joedolson.
Fixes #44267.

git-svn-id: https://develop.svn.wordpress.org/trunk@60891 602fd350-edb4-49c9-b593-d223f7449a82

Author: joedolson

src/wp-admin/css/forms.css

@@ -1453,6 +1453,11 @@ table.form-table td .updated p {
 	font-weight: 600;
 }
 
+.privacy_requests .status-date {
+	display: block;
+	font-weight: 400;
+}
+
 .wp-privacy-request-form {
 	clear: both;
 }

src/wp-admin/includes/class-wp-privacy-requests-table.php

@@ -461,7 +461,7 @@ public function column_status( $item ) {
 		echo esc_html( $status_object->label );
 
 		if ( $timestamp ) {
-			echo ' (' . $this->get_timestamp_as_date( $timestamp ) . ')';
+			echo '<span class="status-date">' . $this->get_timestamp_as_date( $timestamp ) . '</span>';
 		}
 
 		echo '</span>';
@@ -487,7 +487,14 @@ protected function get_timestamp_as_date( $timestamp ) {
 			return sprintf( __( '%s ago' ), human_time_diff( $timestamp ) );
 		}
 
-		return date_i18n( get_option( 'date_format' ), $timestamp );
+		return sprintf(
+			/* translators: 1: privacy request date format, 2: privacy request time format. */
+			__( '%1$s at %2$s' ),
+			/* translators: privacy request date format. See https://www.php.net/manual/en/datetime.format.php */
+			date_i18n( __( 'Y/m/d' ), $timestamp ),
+			/* translators: privacy request time format. See https://www.php.net/manual/en/datetime.format.php */
+			date_i18n( __( 'g:i a' ), $timestamp )
+		);
 	}
 
 	/**

tests/phpunit/tests/admin/wpPrivacyRequestsTable.php

@@ -209,4 +209,41 @@ public function test_get_views_should_return_views_by_default() {
 
 		$this->assertSame( $expected, $this->get_mocked_class_instance()->get_views() );
 	}
+
+	/**
+	 * Test the get_timestamp_as_date method formats timestamps correctly.
+	 *
+	 * @ticket 44267
+	 *
+	 * @covers WP_Privacy_Requests_Table::get_timestamp_as_date
+	 */
+	public function test_get_timestamp_as_date() {
+		$table = $this->get_mocked_class_instance();
+
+		$reflection = new ReflectionClass( $table );
+		$method     = $reflection->getMethod( 'get_timestamp_as_date' );
+		$method->setAccessible( true );
+
+		$date_format = __( 'Y/m/d' );
+		$time_format = __( 'g:i a' );
+
+		$current_time = time();
+
+		$this->assertSame( '', $method->invoke( $table, '' ) );
+
+		// Test recent timestamp (less than 24 hours ago).
+		$recent_time = $current_time - HOUR_IN_SECONDS;
+		$result      = $method->invoke( $table, $recent_time );
+		$this->assertStringContainsString( 'ago', $result );
+
+		$old_time = $current_time - 2 * DAY_IN_SECONDS;
+		$result   = $method->invoke( $table, $old_time );
+
+		$date_part = date_i18n( $date_format, $old_time );
+		$time_part = date_i18n( $time_format, $old_time );
+
+		$this->assertStringContainsString( $date_part, $result );
+		$this->assertStringContainsString( 'at', $result );
+		$this->assertStringContainsString( $time_part, $result );
+	}
 }