From 71fe82cb00d8623421b5613c8f8815d7599ade40 Mon Sep 17 00:00:00 2001 From: Dennis Kraffczyk Date: Sun, 15 Feb 2026 13:56:44 +0100 Subject: [PATCH 1/2] Localize the position and type column --- .../gridView/admin/BoxGridView.class.php | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/wcfsetup/install/files/lib/system/gridView/admin/BoxGridView.class.php b/wcfsetup/install/files/lib/system/gridView/admin/BoxGridView.class.php index 89a2234a35..982ae756bb 100644 --- a/wcfsetup/install/files/lib/system/gridView/admin/BoxGridView.class.php +++ b/wcfsetup/install/files/lib/system/gridView/admin/BoxGridView.class.php @@ -5,6 +5,7 @@ use wcf\acp\form\BoxEditForm; use wcf\data\box\Box; use wcf\data\box\BoxList; +use wcf\data\DatabaseObject; use wcf\data\DatabaseObjectList; use wcf\event\gridView\admin\BoxGridViewInitialized; use wcf\system\gridView\AbstractGridView; @@ -12,6 +13,7 @@ use wcf\system\gridView\GridViewRowLink; use wcf\system\gridView\renderer\NumberColumnRenderer; use wcf\system\gridView\renderer\ObjectIdColumnRenderer; +use wcf\system\gridView\renderer\PhraseColumnRenderer; use wcf\system\interaction\admin\BoxInteractions; use wcf\system\interaction\Divider; use wcf\system\interaction\EditInteraction; @@ -48,6 +50,15 @@ public function __construct() ->sortable(), GridViewColumn::for('boxType') ->label('wcf.acp.box.type') + ->renderer(new class extends PhraseColumnRenderer { + #[\Override] + public function render(mixed $value, DatabaseObject $row): string + { + assert($row instanceof Box); + + return parent::render('wcf.acp.box.type.' . $value, $row); + } + }) ->filter( new SelectFilter( \array_combine( @@ -64,6 +75,15 @@ public function __construct() ->sortable(), GridViewColumn::for('position') ->label('wcf.acp.box.position') + ->renderer(new class extends PhraseColumnRenderer { + #[\Override] + public function render(mixed $value, DatabaseObject $row): string + { + assert($row instanceof Box); + + return parent::render('wcf.acp.box.position.' . $value, $row); + } + }) ->filter( new SelectFilter( \array_combine( From a6d56ab57ee429a52e7cb23309fd573432d2efd1 Mon Sep 17 00:00:00 2001 From: Marcel Werk Date: Mon, 16 Feb 2026 16:45:44 +0100 Subject: [PATCH 2/2] Remove obsolete code --- .../files/lib/system/gridView/admin/BoxGridView.class.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/wcfsetup/install/files/lib/system/gridView/admin/BoxGridView.class.php b/wcfsetup/install/files/lib/system/gridView/admin/BoxGridView.class.php index 982ae756bb..7642fae17c 100644 --- a/wcfsetup/install/files/lib/system/gridView/admin/BoxGridView.class.php +++ b/wcfsetup/install/files/lib/system/gridView/admin/BoxGridView.class.php @@ -54,8 +54,6 @@ public function __construct() #[\Override] public function render(mixed $value, DatabaseObject $row): string { - assert($row instanceof Box); - return parent::render('wcf.acp.box.type.' . $value, $row); } }) @@ -79,8 +77,6 @@ public function render(mixed $value, DatabaseObject $row): string #[\Override] public function render(mixed $value, DatabaseObject $row): string { - assert($row instanceof Box); - return parent::render('wcf.acp.box.position.' . $value, $row); } })