improve constructor and destructor declarations

Author: haohaolee

rest/domain/ElectricityReading.h

@@ -9,6 +9,8 @@ class ElectricityReading {
   using time_point_type = std::chrono::time_point<std::chrono::system_clock>;
 
   ElectricityReading(time_point_type time, size_t reading) : time_(time), reading_(reading) {}
+  ElectricityReading(const ElectricityReading&) = default;
+  ElectricityReading& operator=(const ElectricityReading&) = default;
 
   time_point_type getTime() const { return time_; }
 

rest/domain/MeterReadings.h

@@ -8,10 +8,17 @@
 
 class MeterReadings {
  public:
-  MeterReadings() {}
 
   MeterReadings(std::string smartMeterId, std::list<ElectricityReading> electricityReadings)
-      : smartMeterId_(smartMeterId), electricityReadings_(electricityReadings){};
+      : smartMeterId_(std::move(smartMeterId)), electricityReadings_(std::move(electricityReadings)) {}
+
+  MeterReadings(const MeterReadings&) = default;
+  MeterReadings& operator=(const MeterReadings&) = default;
+
+  MeterReadings(MeterReadings&&) noexcept = default;
+  MeterReadings& operator=(MeterReadings&&) noexcept = default;
+
+  ~MeterReadings() = default;
 
   std::list<ElectricityReading> getElectricityReadings() const { return electricityReadings_; }
 

rest/domain/PricePlan.h

@@ -25,6 +25,12 @@ class PricePlan {
 
     PeakTimeMultiplier(DayOfWeek dayOfWeek, int multiplier) : dayOfWeek(dayOfWeek), multiplier(multiplier) {}
 
+    PeakTimeMultiplier(const PeakTimeMultiplier&) = default;
+    PeakTimeMultiplier& operator=(const PeakTimeMultiplier&) = default;
+    PeakTimeMultiplier(PeakTimeMultiplier&&) noexcept = default;
+    PeakTimeMultiplier& operator=(PeakTimeMultiplier&&) noexcept = default;
+    ~PeakTimeMultiplier() = default;
+
     DayOfWeek dayOfWeek;
     int multiplier;
   };
@@ -35,6 +41,18 @@ class PricePlan {
         unitRate_(unitRate),
         peakTimeMultipliers_(std::move(peakTimeMultipliers)) {}
 
+  // Copyable
+  PricePlan(const PricePlan&) = default;
+
+  // Non-assignable due to const members (immutable value object)
+  PricePlan& operator=(const PricePlan&) = delete;
+  PricePlan& operator=(PricePlan&&) = delete;
+
+  // Movable (for vector initialization)
+  PricePlan(PricePlan&&) noexcept = default;
+
+  ~PricePlan() = default;
+
   std::string getEnergySupplier() const { return energySupplier_; }
 
   std::string getPlanName() const { return planName_; }

rest/service/ElectricityReadingService.h

@@ -13,6 +13,13 @@ class ElectricityReadingService {
   ElectricityReadingService(std::unordered_map<std::string, std::vector<ElectricityReading>> &meterAssociatedReadings)
       : meterAssociatedReadings_(meterAssociatedReadings) {}
 
+  ElectricityReadingService(const ElectricityReadingService&) = delete;
+  ElectricityReadingService& operator=(const ElectricityReadingService&) = delete;
+  ElectricityReadingService(ElectricityReadingService&&) = delete;
+  ElectricityReadingService& operator=(ElectricityReadingService&&) = delete;
+
+  ~ElectricityReadingService() = default;
+
   std::optional<std::vector<ElectricityReading>> GetReading(const std::string &meterId) const {
     auto found = meterAssociatedReadings_.find(meterId);
     if (found != meterAssociatedReadings_.end()) {

rest/service/MeterReadingService.h

@@ -18,6 +18,17 @@
 
 class MeterReadingService {
  public:
+  explicit MeterReadingService(std::unordered_map<std::string, std::vector<ElectricityReading>> &meterAssociatedReadings)
+      : meterAssociatedReadings_(meterAssociatedReadings) {}
+
+  MeterReadingService(const MeterReadingService&) = delete;
+  MeterReadingService& operator=(const MeterReadingService&) = delete;
+
+  MeterReadingService(MeterReadingService&&) = delete;
+  MeterReadingService& operator=(MeterReadingService&&) = delete;
+
+  ~MeterReadingService() = default;
+
   std::optional<std::vector<ElectricityReading>> getReadings(const std::string &smartMeterId) const {
     std::shared_lock<std::shared_mutex> lock(mtx_);
     if (meterAssociatedReadings_.find(smartMeterId) == meterAssociatedReadings_.end()) {
@@ -35,9 +46,6 @@ class MeterReadingService {
                                                   electricityReadings.end());
   }
 
-  explicit MeterReadingService(std::unordered_map<std::string, std::vector<ElectricityReading>> &meterAssociatedReadings)
-      : meterAssociatedReadings_(meterAssociatedReadings) {}
-
  private:
   mutable std::shared_mutex mtx_;
   std::unordered_map<std::string, std::vector<ElectricityReading>> &meterAssociatedReadings_;

rest/service/PricePlanService.h

@@ -34,6 +34,13 @@ class PricePlanService {
   PricePlanService(std::vector<PricePlan> &pricePlans, MeterReadingService &meterReadingService)
       : pricePlans_(pricePlans), meterReadingService_(meterReadingService) {}
 
+  PricePlanService(const PricePlanService&) = delete;
+  PricePlanService& operator=(const PricePlanService&) = delete;
+  PricePlanService(PricePlanService&&) = delete;
+  PricePlanService& operator=(PricePlanService&&) = delete;
+
+  ~PricePlanService() = default;
+
  private:
   const std::vector<PricePlan> &pricePlans_;
   MeterReadingService &meterReadingService_;