Quirks: Review feedback changes

Author: philn

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -1375,7 +1375,9 @@ GstClockTime MediaPlayerPrivateGStreamer::gstreamerPositionFromSinks() const
         gint64 videoPosition = GST_CLOCK_TIME_NONE;
         gst_query_parse_position(query.get(), 0, &videoPosition);
         GST_TRACE_OBJECT(pipeline(), "Video position %" GST_TIME_FORMAT, GST_TIME_ARGS(videoPosition));
-        if (GST_CLOCK_TIME_IS_VALID(videoPosition) && (!GST_CLOCK_TIME_IS_VALID(gstreamerPosition) || (m_playbackRate >= 0 && videoPosition > gstreamerPosition) || (m_playbackRate < 0 && videoPosition < gstreamerPosition)))
+        if (GST_CLOCK_TIME_IS_VALID(videoPosition) && (!GST_CLOCK_TIME_IS_VALID(gstreamerPosition)
+            || (m_playbackRate >= 0 && videoPosition > gstreamerPosition)
+            || (m_playbackRate < 0 && videoPosition < gstreamerPosition)))
             gstreamerPosition = videoPosition;
     }
     return static_cast<GstClockTime>(gstreamerPosition);
@@ -3011,8 +3013,7 @@ void MediaPlayerPrivateGStreamer::createGSTPlayBin(const URL& url)
     if (videoSinkPad)
         g_signal_connect(videoSinkPad.get(), "notify::caps", G_CALLBACK(+[](GstPad* videoSinkPad, GParamSpec*, MediaPlayerPrivateGStreamer* player) {
             player->videoSinkCapsChanged(videoSinkPad);
-        }),
-            this);
+        }), this);
 }
 
 void MediaPlayerPrivateGStreamer::configureVideoDecoder(GstElement* decoder)

Source/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.cpp

@@ -43,7 +43,7 @@ GstElement* GStreamerQuirkAmLogic::createWebAudioSink()
     // On Amlogic we need to set direct-mode=false prop before changing state to READY
     // but this is not possible with autoaudiosink.
     auto sink = makeGStreamerElement("amlhalasink", nullptr);
-    ASSERT_WITH_MESSAGE(sink, "amlhalasink should be available in the system but it is not");
+    RELEASE_ASSERT_WITH_MESSAGE(sink, "amlhalasink should be available in the system but it is not");
     g_object_set(sink, "direct-mode", FALSE, nullptr);
     return sink;
 }

Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.cpp

@@ -50,7 +50,7 @@ GStreamerQuirkRealtek::GStreamerQuirkRealtek()
 GstElement* GStreamerQuirkRealtek::createWebAudioSink()
 {
     auto sink = makeGStreamerElement("rtkaudiosink", nullptr);
-    ASSERT_WITH_MESSAGE(sink, "rtkaudiosink should be available in the system but it is not");
+    RELEASE_ASSERT_WITH_MESSAGE(sink, "rtkaudiosink should be available in the system but it is not");
     g_object_set(sink, "media-tunnel", FALSE, "audio-service", TRUE, nullptr);
     return sink;
 }