Remove old fix for Ctrl+F due to its inconsistency

Author: WebCoder49

CONTRIBUTING.md

@@ -6,7 +6,15 @@
 * The `code-input` element should be easy to use with all popular syntax-highlighting libraries.
 * Any modifications of `code-input` that would be useful for the open-source community but are not core to this functionality should be available as optional plugins in the `plugins` folder. Here's where most feature contributions will go.
 
-To keep this community productive and enjoyable, please [don't break the code of conduct here](https://github.com/WebCoder49/code-input/blob/main/CODE_OF_CONDUCT.md).
+We will generally *not* consider the following contributions:
+* Excess functionality and/or complexity in the main code-input files - these types of contributions should go in the plugin folder instead.
+* Issues that have been closed as not planned in the past (you can search the issue list to check), unless you bring a change that overcomes the reason they were not planned.
+
+This said, if you're not sure whether your change will be accepted, please ask in an issue.
+
+---
+
+To keep this community productive and enjoyable, please [don't break our code of conduct](https://github.com/WebCoder49/code-input/blob/main/CODE_OF_CONDUCT.md).
 
 ---
 # Ways you could contribute:

README.md

@@ -88,11 +88,6 @@ The next step is to set up a `template` to link `code-input` to your syntax-high
            * argument to the highlight function to be used for getting data- attribute values
            * and using the DOM for the code-input */,
 
-    true /* Optional - Leaving this as true uses code-input's default fix for preventing duplicate
-          * results in Ctrl+F searching from the input and result elements, and setting this to false
-          * indicates your highlighting function implements its own fix. The default fix works by moving
-          * text content from elements to CSS ::before pseudo-elements after highlighting. */
-
     [] // Array of plugins (see below)
   ));
   ```

code-input.js

@@ -108,7 +108,6 @@ var codeInput = {
         if(!(typeof template.includeCodeInputInHighlightFunc == "boolean" || template.includeCodeInputInHighlightFunc instanceof Boolean)) throw TypeError(`code-input: Template for "${templateName}" invalid, because the includeCodeInputInHighlightFunc value provided is not a true or false; it is "${template.includeCodeInputInHighlightFunc}". Please make sure you use one of the constructors in codeInput.templates, and that you provide the correct arguments.`);
         if(!(typeof template.preElementStyled == "boolean" || template.preElementStyled instanceof Boolean)) throw TypeError(`code-input: Template for "${templateName}" invalid, because the preElementStyled value provided is not a true or false; it is "${template.preElementStyled}". Please make sure you use one of the constructors in codeInput.templates, and that you provide the correct arguments.`);
         if(!(typeof template.isCode == "boolean" || template.isCode instanceof Boolean)) throw TypeError(`code-input: Template for "${templateName}" invalid, because the isCode value provided is not a true or false; it is "${template.isCode}". Please make sure you use one of the constructors in codeInput.templates, and that you provide the correct arguments.`);
-        if(!(typeof template.autoDisableDuplicateSearching == "boolean" || template.autoDisableDuplicateSearching instanceof Boolean)) throw TypeError(`code-input: Template for "${templateName}" invalid, because the autoDisableDuplicateSearching value provided is not a true or false; it is "${template.autoDisableDuplicateSearching}". Please make sure you use one of the constructors in codeInput.templates, and that you provide the correct arguments.`);
         if(!Array.isArray(template.plugins)) throw TypeError(`code-input: Template for "${templateName}" invalid, because the plugin array provided is not an array; it is "${template.plugins}". Please make sure you use one of the constructors in codeInput.templates, and that you provide the correct arguments.`);
 
         template.plugins.forEach((plugin, i) => {
@@ -166,18 +165,11 @@ var codeInput = {
          * @param {codeInput.Plugin[]} plugins - An array of plugin objects to add extra features - see `codeInput.Plugin`
          * @returns {codeInput.Template} template object
          */
-        constructor(highlight = function () { }, preElementStyled = true, isCode = true, includeCodeInputInHighlightFunc = false, autoDisableDuplicateSearching = true, plugins = []) {
-            // @deprecated to support old function signature without autoDisableDuplicateSearching
-            if(Array.isArray(autoDisableDuplicateSearching)) {
-                plugins = autoDisableDuplicateSearching;
-                autoDisableDuplicateSearching = true;
-            }
-
+        constructor(highlight = function () { }, preElementStyled = true, isCode = true, includeCodeInputInHighlightFunc = false, plugins = []) {
             this.highlight = highlight;
             this.preElementStyled = preElementStyled;
             this.isCode = isCode;
             this.includeCodeInputInHighlightFunc = includeCodeInputInHighlightFunc;
-            this.autoDisableDuplicateSearching = autoDisableDuplicateSearching;
             this.plugins = plugins;
         }
 
@@ -210,15 +202,6 @@ var codeInput = {
          */
         includeCodeInputInHighlightFunc = false;
 
-        /**
-         * Leaving this as true uses code-input's default fix for preventing duplicate results in Ctrl+F searching
-         * from the input and result elements, and setting this to false indicates your highlighting function implements
-         * its own fix.
-         * 
-         * The default fix works by moving text content from elements to CSS ::before pseudo-elements after highlighting.
-         */
-        autoDisableDuplicateSearching = true;
-
         /**
          * An array of plugin objects to add extra features - 
          * see `codeInput.Plugin`.
@@ -251,7 +234,6 @@ var codeInput = {
                 true, // preElementStyled
                 true, // isCode
                 false, // includeCodeInputInHighlightFunc
-                true, // autoDisableDuplicateSearching
                 plugins
             );
         },
@@ -270,7 +252,6 @@ var codeInput = {
                 false, // preElementStyled
                 true, // isCode
                 false, // includeCodeInputInHighlightFunc
-                true, // autoDisableDuplicateSearching
                 plugins
             );
         },
@@ -297,7 +278,6 @@ var codeInput = {
                 includeCodeInputInHighlightFunc: true,
                 preElementStyled: true,
                 isCode: false,
-                autoDisableDuplicateSearching: true,
                 plugins: plugins,
             }
         },
@@ -322,7 +302,6 @@ var codeInput = {
                 includeCodeInputInHighlightFunc: true,
                 preElementStyled: true,
                 isCode: false,
-                autoDisableDuplicateSearching: true,
 
                 rainbowColors: rainbowColors,
                 delimiter: delimiter,
@@ -514,7 +493,6 @@ var codeInput = {
         * to syntax-highlight it. */
 
         needsHighlight = false; // Just inputted
-        // needsDisableDuplicateSearching = false; // Just highlighted
 
         /**
          * Highlight the code ASAP
@@ -540,14 +518,7 @@ var codeInput = {
             if(this.needsHighlight) {
                 this.update();
                 this.needsHighlight = false;
-                // this.needsDisableDuplicateSearching = true;
             }
-            // if(this.needsDisableDuplicateSearching && this.codeElement.querySelector("*") != null) {
-            //     // Has been highlighted
-            //     this.resultElementDisableSearching();
-            //     this.needsDisableDuplicateSearching = false;
-            // }
-
             window.requestAnimationFrame(this.animateFrame.bind(this));
         }
 
@@ -592,30 +563,6 @@ var codeInput = {
             return text.replace(new RegExp("&amp;", "g"), "&").replace(new RegExp("&lt;", "g"), "<").replace(new RegExp("&gt;", "g"), ">"); /* Global RegExp */
         }
 
-        /**
-         * Make the text contents of highlighted code in the `<pre><code>` result element invisible to Ctrl+F by moving them to a data attribute
-         * then the CSS `::before` pseudo-element on span elements with the class code-input_searching-disabled. This function is called recursively
-         * on all child elements of the <code> element.
-         * 
-         * @param {HTMLElement} element The element on which this is carried out recursively. Optional - defaults to the `<pre><code>`'s `<code>` element. 
-         */
-        resultElementDisableSearching(element=this.preElement) {
-            for (let i = 0; i < element.childNodes.length; i++) {
-                let content = element.childNodes[i].textContent;
-            
-                if (element.childNodes[i].nodeType == 3) {
-                    // Turn plain text node into span element
-                    element.replaceChild(document.createElement('span'), element.childNodes[i]);
-                    element.childNodes[i].classList.add("code-input_searching-disabled")
-                    element.childNodes[i].setAttribute("data-content", content);
-                    element.childNodes[i].innerText = '';
-                } else {
-                    // Recurse deeper
-                    this.resultElementDisableSearching(element.childNodes[i]);
-                }
-            }
-        }
-
         /**
          * Get the template object this code-input element is using.
          * @returns {Object} - Template object